Skip to content

Fix JSONDecodeError in E2E tests when stdout is empty or warning-only - #93

Merged
mvfc merged 3 commits into
mc/organization_exportfrom
fix-e2e-parse-json-output-8467635074331933391
Oct 27, 2026
Merged

mvfc merged 3 commits into
mc/organization_exportfrom
fix-e2e-parse-json-output-8467635074331933391

Conversation

@mvfc

@mvfc mvfc commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Updated parse_json_output in tests/test_e2e.py to return an empty list [] when bw CLI output is empty or contains only warning messages, preventing json.decoder.JSONDecodeError failures during E2E test runs. Added corresponding unit tests in tests/test_e2e_helpers.py.


PR created automatically by Jules for task 8467635074331933391 started by @mvfc

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no outstanding issues were found.

Summary

The PR adds an initial bw sync to the E2E session setup and tests that parse_json_output rejects empty or warning-only output.

  • E2E sessions sync before tests use the unlocked account.
  • Parser helper tests now cover empty and warning-only text.

Reviews (3) · Last reviewed commit: "Ensure bw sync in bw_session fixture to ..." · Reviewed by Greptile

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5a8113d0-7226-45c4-862b-62996a5b0b32

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread tests/test_e2e.py Outdated
mvfc and others added 2 commits October 27, 2026 08:54
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…E2E tests

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@mvfc
mvfc merged commit e2a3609 into mc/organization_export Oct 27, 2026
3 checks passed
@mvfc
mvfc deleted the fix-e2e-parse-json-output-8467635074331933391 branch October 27, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant