Repository navigation
Limit RDRAM initialization to 4 chips when Expansion Pak is marked as unused - #10
Open
marian-m12l wants to merge 3 commits into
Open
marian-m12l wants to merge 3 commits into
marian-m12l wants to merge 3 commits into
Conversation
…s active and breaks the warm boot loop that measures memsize by testing each bank
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy of PR DragonMinded/libdragon#1009. See the corresponding conversation to see if this is worth merging or not.
This PR is an attempt at addressing issue DragonMinded/libdragon#425.
It limits RDRAM chips discovery/initialization to 4 chips, essentially simulating running on a console with Jumper Pak only.
It currently relies on the Expansion Pak being marked as "unused" (value 0x01) in the Homebrew ROM header (bits 2-3 at offset 0x3f), but I can see how this may not be wanted (this header is informative, after all). As an alternative, the flag to ignore Expansion Pak could be added by n64tool in another unused header field (e.g. reserved field at offset 0x18), or even in the TOC maybe?
I've tested on real hardware (PAL N64) with a dev IPL3 (prod IPL3 signing underway). On ares it seems to always take the warm boot path?
I have yet to test writing/reading past the 4MiB threshold, but I expect it to fail on hardware, but not on ares (as evidenced by the need to limit the warm boot test loop to 4 chips).
I tried to keep the diff concise yet readable. I'm eager to hear your thoughts on this, especially regarding how to handle the iQue as I'm not familiar with its idiosyncrasies.