feat(kafka): manage topic access grants - #773
Merged
Merged
Conversation
Contributor
📝 Changelog previewBelow is a preview of the Changelog that will be added to the next release. Only commit messages that follow the Conventional Commits specification will be included in the Changelog. v5.49.0 - 2026-09-10Full Changelog: v5.48.0...v5.49.0 🚀 Features
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new revoke-grant command has avoidable UX/API inconsistencies (argument order vs grant-access and validation placement) that should be addressed before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds Kafka topic access grant management capabilities to the CLI by introducing commands to list and revoke ACL grants, backed by new GraphQL query/mutation support.
Changes:
- Add
kafka list-grantsto display ACL grants for a Kafka topic (table or JSON output). - Add
kafka revoke-grantto revoke a specific subject’s access level on a Kafka topic, including grant-aware autocompletion. - Extend generated GraphQL client code for fetching grants and revoking them; remove leftover debug dumping in config code.
File summaries
| File | Description |
|---|---|
| internal/naisapi/gql/generated.go | Adds genqlient-generated types and operations for GetKafkaTopicGrants and RevokeAccessFromKafkaTopic. |
| internal/kafka/kafka.go | Introduces Grant model plus API helpers to list grants and revoke a grant via GraphQL. |
| internal/kafka/command/revoke_grant.go | New kafka revoke-grant command and grant-aware argument autocompletion. |
| internal/kafka/command/list_grants.go | New kafka list-grants command for listing topic ACL entries. |
| internal/kafka/command/list_grants_test.go | Adds tests for the new commands and grant table headings. |
| internal/kafka/command/flag/flag.go | Tightens access validation (reject empty) and adds ListGrants flags. |
| internal/kafka/command/command.go | Registers new subcommands and adds topic name autocompletion helper. |
| internal/config/config.go | Removes accidental debug spew.Dump usage. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+25
to
+33
| ValidateFunc: validation.RequireTeamAndEnvironment(parentFlags), | ||
| AutoCompleteFunc: autoCompleteKafkaGrantArguments(parentFlags), | ||
| RunFunc: func(ctx context.Context, args *naistrix.Arguments, out *naistrix.OutputWriter) error { | ||
| topicName := args.Get("topic") | ||
| subject := kafkaApplicationName(args.Get("username")) | ||
| access := flag.KafkaTopicGrantAccess(args.Get("access")) | ||
| if err := access.Validate(); err != nil { | ||
| return err | ||
| } |
Comment on lines
+20
to
+24
| Args: []naistrix.Argument{ | ||
| {Name: "topic"}, | ||
| {Name: "username"}, | ||
| {Name: "access"}, | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.