Repository navigation
fix(i18n): honor a custom outputPath.browser folder when translating federation output - #176
Open
JohnYoungers wants to merge 1 commit into
Conversation
JohnYoungers
marked this pull request as draft
October 15, 2026 12:56
… federation output translateFederationArtifacts hardcoded a 'browser' segment, so a build with outputPath.browser set to another folder (or to an empty string) looked for the federation artifacts in a folder that does not exist. Pass the configured folder through instead.
JohnYoungers
force-pushed
the
fix/i18n-honor-browser-output-folder
branch
from
October 19, 2026 12:33
9fa3f43 to
e498b83
Compare
JohnYoungers
marked this pull request as ready for review
October 19, 2026 12:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
translateFederationArtifactsjoins a literal'browser'segment onto the output base, but@angular/buildlets you change that folder throughoutputPath.browser, including setting it to an empty string so the output sits directly under the base:The main build respects this, but the i18n step then looks for the federation artifacts in
<base>/browser/<locale>, which does not exist, and the build fails because it expects a folder namedbrowser.Change
translateFederationArtifactstakes an optionalbrowserFolderargument, defaulting to'browser', so existing callers behave as before.outputOptions.browser, which keeps an empty string as is.Tests
Two new cases in
i18n.spec.tscover a custom folder and an empty folder. They normalise path separators so they also run on Windows. The suite has 5 other failing i18n tests on Windows from path separators, the same 5 as onmain.Not covered
remote/builder.ts,update-index-html.ts(SSR) andnode-preload.tsalso assume abrowserfolder. I left them alone because they are separate builders and I haven't checked them against a real layout.🤖 Generated with Claude Code