Remove obsolete knobs and compat paths; strict input validation; docs cleanup - #113
Merged
Merged
Conversation
… cleanup - Remove placement_rounds, acceptance_rule, integer/blank flow_policy, ngraph.dsl.selectors re-exports, edge_select on shortest_path_cost and k_shortest_paths, include_flow_summary, CapacityEnvelope flow summaries, active_seed, inspect --output and the pandas dependency (CHANGELOG [Unreleased] lists everything) - Raise on inputs that were silently ignored: unknown keys in any scenario section, mode on a bound context, alpha with alpha_from_step, non-integer parallelism, invalid hardware counts, duplicate risk group names - Round exclusive link-end BOM counts up; show enum step parameters by name in inspect; send inspect errors to stderr - Docs: check every reference page against the code, drop history wording and filler, rewrite the integration test README, regenerate the API reference and pipeline diagram - Fix the scenario_4 fixture (leaf-spine links were never created and every MaxFlow returned 0) and integration tests that could not fail - Dev tooling: emphasis and fenced-code handling in the API doc generator, per-profile complexity fits in dev/perf, tests under tests/dev Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
placement_rounds,acceptance_rule, integer/blankflow_policy, thengraph.dsl.selectorsre-exports,edge_selectonshortest_path_cost/k_shortest_paths,include_flow_summary,CapacityEnvelopeflow summaries,active_seed,inspect --output, and thepandasdependency. The[Unreleased]section of CHANGELOG.md lists every item.modeon a bound context,alphawithalpha_from_step, non-integerparallelism, invalid hardware counts and duplicate risk group names now raise instead of being ignored.inspect --detailshows enum parameters by name;inspecterrors go to stderr.>= 0; fixed, and the tests now assert concrete capacities. Newtests/dev/covers two dev-tooling fixes (API doc generator, per-profile perf fits).Test plan
bash .superset/workspace.sh check: 1284 tests pass, 93% coverage, API reference in sync, strict docs buildpre-commit run --all-files🤖 Generated with Claude Code