Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a98549dcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Handle both 'edges' and 'links' keys for compatibility | ||
| edges_key = "edges" if "edges" in graph_data else "links" | ||
| graph = nx.node_link_graph(graph_data, edges=edges_key) | ||
| graph = nx.node_link_graph(graph_data, edges="edges") |
There was a problem hiding this comment.
links
Keep selecting the edge key from the serialized graph instead of hard-coding edges. When from_results() loads an existing BuildGraph result whose node-link payload stores its edge list under links—a format this method explicitly supported before this change—nx.node_link_graph(..., edges="edges") looks for a nonexistent key and visualization fails rather than loading the graph. The repository's DC-BB result handling also continues to accept both links and edges, so removing the fallback here makes the visualization path inconsistent.
Useful? React with 👍 / 👎.
1 participant
Align NetLab 0.4.0 with current NetGraph scenarios and results, and add isolated Superset workspace setup. Fix directional BAC and iteration plots, regenerate simulation fixtures, and simplify documentation.
Validation: