Skip to content

refactor(thumbnail-loader): to player thumbnail loader - #17564

Merged
alperozturk96 merged 1 commit into
masterfrom
refactor-thumbnail-loader
Sep 7, 2026
Merged

refactor(thumbnail-loader): to player thumbnail loader#17564
alperozturk96 merged 1 commit into
masterfrom
refactor-thumbnail-loader

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Renames the ThumbnailLoader to PlayerThumbnailLoader so that we don't get confusion between ThumbnailGenerator.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness5858
Dodgy code195195
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3737
Security1919
Total373373

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/34091222481/artifacts/10007085958
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thank you for improving code readability, definitely approve!

@alperozturk96
alperozturk96 merged commit 3c00d5e into master Sep 7, 2026
22 of 24 checks passed
@alperozturk96
alperozturk96 deleted the refactor-thumbnail-loader branch September 7, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants