Skip to content

Avoid edit button to cover cursor when the text is scrolled due to the user deleting an entire line - #3329

Open
daniele-verducci wants to merge 2 commits into
mainfrom
fix/2272-do-not-cover-cursor-while-editing
Open

Avoid edit button to cover cursor when the text is scrolled due to the user deleting an entire line#3329
daniele-verducci wants to merge 2 commits into
mainfrom
fix/2272-do-not-cover-cursor-while-editing

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fix: #2272 (comment)

How to repro:

  • Write a long text so that the view will scroll
  • Delete a line so it scrolls back due to the shorter text
  • The FAB covers the text and makes impossible to see what is being written/deleted

🖼️ Screenshots

🏚️ Before 🏡 After
before.webm after.webm

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

… to the user deleting an entire line

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@codacy-production

codacy-production Bot commented Sep 1, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/notes-android/actions/runs/33493461810/artifacts/9797670470
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/notes-android/actions/runs/33732355255/artifacts/9884918645
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit button overlaps content

1 participant