Skip to content

test: stabilize currency caret setup during qualification - #103

Merged
JJLiebig merged 1 commit into
mainfrom
fix/currency-caret-qualification
Oct 20, 2026
Merged

JJLiebig merged 1 commit into
mainfrom
fix/currency-caret-qualification

Conversation

@JJLiebig

@JJLiebig JJLiebig commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

The v2.7.0 publish qualification failed because the currency journey checked the formatted value, then moved the caret while react-number-format could still restore its previous position in a deferred callback. CI observed [9,9] instead of [2,2].

Retry the existing keyboard navigation within the caret-position poll. This makes the insertion setup recover from that deferred update while retaining the actual insertion, Backspace, cents, large decimal string, and overflow assertions. Package code, release tags, and workflow gates are unchanged.

Validation on a24f2b4:

  • just pre-commit passed (format, lint, supply-chain watchlist, all four TypeScript projects).
  • Currency journey passed 20 repeats per target on desktop and mobile: 40/40, zero test retries.
  • A temporary controlled-interleaving reproduction released the formatter's actual deferred callback after Home: the original setup failed with CI's exact [9,9] result; the revised setup passed and preserved insertion/Backspace behavior. The diagnostic harness is not part of this patch.
  • GitHub qualification passed: 57/57 tests, two agent steps replayed, zero model calls. Run: https://github.com/nextidemedia/ui/actions/runs/39402810934
  • Review Suite fast dual signoff passed with no findings (rvw_9fa45c3f).

Original failure: https://github.com/nextidemedia/ui/actions/runs/39401766167

@JJLiebig
JJLiebig merged commit 05587fa into main Oct 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant