Repository navigation
test: stabilize currency caret setup during qualification - #103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2.7.0 publish qualification failed because the currency journey checked the formatted value, then moved the caret while react-number-format could still restore its previous position in a deferred callback. CI observed
[9,9]instead of[2,2].Retry the existing keyboard navigation within the caret-position poll. This makes the insertion setup recover from that deferred update while retaining the actual insertion, Backspace, cents, large decimal string, and overflow assertions. Package code, release tags, and workflow gates are unchanged.
Validation on a24f2b4:
just pre-commitpassed (format, lint, supply-chain watchlist, all four TypeScript projects).[9,9]result; the revised setup passed and preserved insertion/Backspace behavior. The diagnostic harness is not part of this patch.Original failure: https://github.com/nextidemedia/ui/actions/runs/39401766167