Skip to content

test: await select option focus before keyboard navigation - #104

Merged
JJLiebig merged 1 commit into
mainfrom
fix/select-focus-qualification
Oct 20, 2026
Merged

JJLiebig merged 1 commit into
mainfrom
fix/select-focus-qualification

Conversation

@JJLiebig

@JJLiebig JJLiebig commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

The v2.7.0 publish retry exposed a keyboard-selection race: the region menu was visible, but its opening focus transition had not necessarily finished before the test sent Home, ArrowDown and Enter. The trigger remained at its empty placeholder instead of selecting Americas.

Wait for the first option to receive focus before navigation, and for Americas to receive focus before committing. Existing keyboard navigation, validation and focus-restoration assertions remain intact; package code and workflow gates are unchanged.

Validation on 389917d:

  • The keyboard-controls journey passed 20 repeats per target on desktop and mobile: 40/40, zero test retries.
  • just pre-commit passed formatting, lint, supply-chain checks and all four TypeScript projects.
  • Review Suite fast dual signoff passed with no findings (rvw_cdffc228).
  • GitHub qualification passed: 57/57 tests, two agent steps replayed. Run: https://github.com/nextidemedia/ui/actions/runs/39403889047

Failure evidence: https://github.com/nextidemedia/ui/actions/runs/39401766167/attempts/2

@JJLiebig
JJLiebig merged commit 4c6efd5 into main Oct 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant