Repository navigation
test: await select option focus before keyboard navigation - #104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2.7.0 publish retry exposed a keyboard-selection race: the region menu was visible, but its opening focus transition had not necessarily finished before the test sent Home, ArrowDown and Enter. The trigger remained at its empty placeholder instead of selecting Americas.
Wait for the first option to receive focus before navigation, and for Americas to receive focus before committing. Existing keyboard navigation, validation and focus-restoration assertions remain intact; package code and workflow gates are unchanged.
Validation on 389917d:
just pre-commitpassed formatting, lint, supply-chain checks and all four TypeScript projects.Failure evidence: https://github.com/nextidemedia/ui/actions/runs/39401766167/attempts/2