Repository navigation
update support for (mostly) simple math ops. - #76
Merged
Merged
Conversation
…at least for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates support for a variety of math ops, e.g.
cloglog,nEquals, and (the only matrix one)inverse, to give examples of different categories. There are quite a few.Some of these needed new implementations. Some needed nCompiler opDefs and/or C++ back-ends. Some had duplicate definitions in
nimbleModelandnCompiler. For now those are resovled by moving to nCompiler. I realized that some of them maybe really belong only innimbleModel(they are not really needed as a general op in nCompiler), and lost track of that distinction when doing this. Now that things are in general more cleaned up (e.g. quite a few had uncompiled but not compiled support), it would be eeasier to move them back to nimbleModel later. I'd suggest we keep as is for now for purposes of working on nimble2, and revisit later.