Repository navigation
Fix linux-arm64 CRAN test failure in minqa comparison - #7
Open
mattfidler wants to merge 2 commits into
Open
mattfidler wants to merge 2 commits into
mattfidler wants to merge 2 commits into
Conversation
On linux-arm64 the FMA-contracted minqa build reaches the same permutation-invariant chebyquad minimum with two coordinates swapped, failing the positional par comparison in test-minqa.R.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
- Coverage 92.00% 91.80% -0.21%
==========================================
Files 26 26
Lines 3916 3917 +1
==========================================
- Hits 3603 3596 -7
- Misses 313 321 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CRAN linux-arm64 check failure (https://github.com/r-devel/linux-arm64-checks/tree/HEAD/RcppTrust):
Cause
On aarch64, gfortran contracts minqa's Fortran to FMA while our ports forbid contraction, so rounding differs. The chebyquad objective is invariant under permutation of
x, so both runs reach the same minimum with two coordinates swapped. The non-bitwise branch ofexpectSameAsMinqa()comparedparpositionally.Fix
expectSameAsMinqa()gainspermInvariant; when set (non-bitwise platforms only),paris compared sorted andfvalwith tolerance1e-6.bobyqa()andnewuoa().Testing
devtools::test(filter='minqa')passes on x86_64 (bitwise branch).bitwiseforced toFALSElocally (exercises the arm64 branch). Not run on actual arm64 hardware.🤖 Generated with Claude Code