Repository navigation
Skip NEWUOA ierr = 3 test when R lacks long double - #8
Open
mattfidler wants to merge 1 commit into
Open
mattfidler wants to merge 1 commit into
mattfidler wants to merge 1 commit into
Conversation
The unbounded sum(x) objective reaches the ierr = 3 exit only through rounding that depends on sum() accumulating in long double, so it fails on CRAN's noLD check (R built with --disable-long-double).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 26 26
Lines 3917 3917
=======================================
Hits 3596 3596
Misses 321 321 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CRAN noLD check failure (https://www.stats.ox.ac.uk/pub/bdr/noLD/RcppTrust.out).
The
test-minqa.RNEWUOA test expectingierr = 3("failed to reduce q") uses an unboundedsum(x)objective whose exit path depends on rounding at huge magnitudes. Besides being x86_64-specific, it depends onsum()accumulating in long double: on the noLD build NEWUOA exits normally (ierr = 0). Rewriting the objective asx[1]+x[2]+x[3]also givesierr = 0on a normal build, confirming the dependence.The assertion is now additionally guarded by
capabilities("long.double"). Solver code is unchanged; NEWS.md updated.Generated with Claude Code