Skip to content

style: correct the code style in the hover status - #1080

Open
btea wants to merge 1 commit into
nodejs:mainfrom
btea:style/dropdown-code
Open

style: correct the code style in the hover status#1080
btea wants to merge 1 commit into
nodejs:mainfrom
btea:style/dropdown-code

Conversation

@btea

@btea btea commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description

The code in the history change dropdown menu has the wrong color and is not clear when hovering.

before after
image image

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format:check & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@btea
btea requested a review from a team as a code owner September 3, 2026 03:02
@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Sep 3, 2026 3:03am UTC

Request Review

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.60%. Comparing base (da5d8e6) to head (b5f41c4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
+ Coverage   90.57%   90.60%   +0.02%     
==========================================
  Files         217      217              
  Lines       20755    20800      +45     
  Branches     1969     1974       +5     
==========================================
+ Hits        18799    18845      +46     
+ Misses       1949     1948       -1     
  Partials        7        7              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: unchanged (1.38 s → 1.38 s)
  • Peak memory: 4.8% higher (348.65 MB → 365.45 MB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 15.0% slower (16.28 s → 18.73 s)
  • Peak memory: 1.3% higher (2.33 GB → 2.36 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 14.1% slower (8.67 s → 9.89 s)
  • Peak memory: 10.3% lower (1.84 GB → 1.65 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 37.6% slower (6.44 s → 8.86 s)
  • Peak memory: 8.0% lower (1.86 GB → 1.71 GB)

orama-db Generator

Output size: 1 file changed · net -1.00 B

File size details
File Main PR Change
orama-db.json 9.26 MB 9.26 MB -1.00 B (-0.0%)

Performance estimate (single CI run)

  • Generation time: 53.0% slower (6.85 s → 10.48 s)
  • Peak memory: 2.2% lower (1.84 GB → 1.80 GB)

web Generator

Output size: 3 files changed · net +32.00 B

File size details
File Main PR Change
assets/style-CGabmPaa.css 137.13 KB +137.13 KB
assets/style-DSrWCPe1.css 136.96 KB -136.96 KB (-100.0%)
all.html 32.21 MB 32.21 MB -142.00 B (-0.0%)

Performance estimate (single CI run)

  • Generation time: 13.2% slower (69.00 s → 78.14 s)
  • Peak memory: 8.9% lower (6.11 GB → 5.57 GB)

@AugustinMauroy

Copy link
Copy Markdown
Member

i was wondering if this style can be applied in the ui-component package in upstream

@btea

btea commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Although it seems to be related to the theme style, it has display issues in the default theme (white), so I think the component should be modified accordingly.

@ovflowd

ovflowd commented Sep 3, 2026

Copy link
Copy Markdown
Member

Hey @btea would you mind adding this upstream? :)

@btea

btea commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@ovflowd I have created a pr nodejs/nodejs.org#9142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants