-
-
Notifications
You must be signed in to change notification settings - Fork 36.7k
build, doc: move to redesign #62045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avivkeller
wants to merge
8
commits into
nodejs:main
Choose a base branch
from
avivkeller:doc/redesign
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
build, doc: move to redesign #62045
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b92ca8e
build, doc: move to redesign
avivkeller c06db26
fixup!
avivkeller 39e57ff
fixup!
avivkeller c10a348
fixup! try single threaded?
avivkeller f9d8bd7
fixup!
avivkeller 8b5681a
fixup! endif
avivkeller 6d9b225
fixup! do we still need threads after mem improve?
avivkeller ad093c0
fixup!
avivkeller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { join } from 'node:path'; | ||
| import { pathToFileURL } from 'node:url'; | ||
|
|
||
| const fromRoot = (path) => | ||
| pathToFileURL(join(import.meta.dirname, '..', '..', path)).href; | ||
|
|
||
| export default { | ||
| extends: '@node-core/doc-kit/config', | ||
|
|
||
| target: ['api-links'], | ||
|
|
||
| global: { | ||
| input: ['lib/*.js'], | ||
|
|
||
| changelog: fromRoot('CHANGELOG.md'), | ||
| }, | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was dropping
llms.txtintentional?The rule is removed here, and I don't see
llms-txtin the new doc-kit config. Release tooling still expectsdocs/llms.txt, so I wanted to check whether that needs updating too.