vfs: resolve symlinks when checking rename descendants - #65904
Open
trivikr wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
needs-ci
trivikr
added
the
request-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65904 +/- ##
==========================================
+ Coverage 90.17% 90.22% +0.05%
==========================================
Files 771 771
Lines 265470 265475 +5
Branches 50463 50512 +49
==========================================
+ Hits 239383 239531 +148
+ Misses 17055 16906 -149
- Partials 9032 9038 +6
🚀 New features to boost your workflow:
|
Check resolved source and destination parent paths before renaming a directory to prevent moving it into its own subtree through a symlink. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex
trivikr
force-pushed
the
vfs-rename-dir-symlink
branch
from
September 11, 2026 03:40
648406e to
7510763
Compare
Collaborator
github-actions
Bot
added
request-ci-failed
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
added
author ready
nodejs-github-bot
added
the
lacks-second-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65903
Check resolved source and destination parent paths before renaming a directory to prevent moving it into its own subtree through a symlink.
Assisted-by: codex