Skip to content

lib: put node:bench behind an --experimental-bench flag - #65920

Open
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/node-bench-flag
Open

lib: put node:bench behind an --experimental-bench flag#65920
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/node-bench-flag

Conversation

@jasnell

@jasnell jasnell commented Sep 8, 2026

Copy link
Copy Markdown
Member

Stacks after #65919 .. the first commit here is from that

The second commit puts the experimental node:bench properly behind the --experimental-bench flag, which I completely missed on the initial landing.

@jasnell
jasnell requested review from ljharb and mcollina September 8, 2026 21:22
@jasnell jasnell added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. experimental Issues and PRs related to experimental features. labels Sep 8, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/loaders
  • @nodejs/performance
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 8, 2026
@jasnell
jasnell force-pushed the jasnell/node-bench-flag branch from 7575fec to 79fa17e Compare September 8, 2026 21:32
@nodejs-github-bot

This comment was marked as outdated.

@jasnell
jasnell force-pushed the jasnell/node-bench-flag branch from 79fa17e to b3204fc Compare September 9, 2026 01:25
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@meixg meixg added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 9, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 9, 2026
@nodejs-github-bot

This comment was marked as duplicate.

@aduh95

This comment was marked as resolved.

@meixg

This comment was marked as resolved.

@jasnell
jasnell force-pushed the jasnell/node-bench-flag branch from b3204fc to c27bdef Compare September 10, 2026 20:03
@jasnell jasnell added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 10, 2026
@nodejs-github-bot

This comment was marked as outdated.

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
jasnell force-pushed the jasnell/node-bench-flag branch from c27bdef to 2f039f1 Compare September 10, 2026 23:02
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (0de4fcc) to head (2f039f1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65920      +/-   ##
==========================================
+ Coverage   90.17%   90.18%   +0.01%     
==========================================
  Files         771      771              
  Lines      265470   265510      +40     
  Branches    50463    50463              
==========================================
+ Hits       239383   239455      +72     
+ Misses      17055    17006      -49     
- Partials     9032     9049      +17     
Files with missing lines Coverage Δ
lib/internal/bench_runner/cli.js 94.14% <100.00%> (+0.02%) ⬆️
lib/internal/bootstrap/realm.js 96.99% <100.00%> (+0.01%) ⬆️
lib/internal/process/pre_execution.js 97.41% <100.00%> (+0.03%) ⬆️
src/node_builtins.cc 77.66% <100.00%> (+0.07%) ⬆️
src/node_options.cc 80.46% <100.00%> (+0.29%) ⬆️
src/node_options.h 95.61% <100.00%> (+0.03%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. c++ Issues and PRs that require attention from people who are familiar with C++. experimental Issues and PRs related to experimental features. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants