Skip to content

doc,test: account for OpenSSL 4.1 behaviours - #65956

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:openssl-4.1-compat
Open

doc,test: account for OpenSSL 4.1 behaviours#65956
panva wants to merge 1 commit into
nodejs:mainfrom
panva:openssl-4.1-compat

Conversation

@panva

@panva panva commented Sep 10, 2026

Copy link
Copy Markdown
Member

Accounts for OpenSSL 4.1 behaviours in the test suite and corrects the X509Certificate documentation to say the behaviour follows the OpenSSL default rather than prescribing what the default on a particular version is.

Refs: https://openssl-library.org/post/2026-09-09-openssl-4.1-alpha/

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@panva
panva requested a review from richardlau September 10, 2026 10:30
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 10, 2026
@panva

panva commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

cc @mcollina @pimterry because of the X509Certificate docs correction.

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (b805fb5) to head (5cabde3).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #65956   +/-   ##
=======================================
  Coverage   90.17%   90.18%           
=======================================
  Files         771      771           
  Lines      265489   265489           
  Branches    50471    50470    -1     
=======================================
+ Hits       239405   239428   +23     
+ Misses      17042    17004   -38     
- Partials     9042     9057   +15     

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 10, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 10, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants