test_runner: fix quote escaping in JUnit - #65971
Open
hanityx wants to merge 1 commit into
Open
Conversation
Escape XML content before replacing double quotes and line feeds. Add a snapshot test for repeated quotes, literal quote references, and quotes mixed with ampersands, less-than signs, or a newline. Signed-off-by: hanityx <hanityx@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65971 +/- ##
==========================================
+ Coverage 90.16% 90.18% +0.02%
==========================================
Files 771 771
Lines 265445 265470 +25
Branches 50455 50459 +4
==========================================
+ Hits 239329 239421 +92
+ Misses 17056 17002 -54
+ Partials 9060 9047 -13
🚀 New features to boost your workflow:
|
meixg
approved these changes
Sep 11, 2026
meixg
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
panva
added
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double quotes in JUnit attribute values are escaped twice: first as
", then as&quot;. An XML reader gets the text"instead of a double quote.
Call
escapeContent()before replacing quotes and newlines.Add a snapshot test for repeated quotes, literal
", and quotesmixed with
&,<, or a newline.Refs: #60274