stream: destroy half-open sockets after iteration - #65986
Open
mcollina wants to merge 1 commit into
Open
Conversation
Async iteration left the writable side of `allowHalfOpen` duplexes open
after clean EOF. For `net.Socket` instances, this retained a live handle
after the peer disconnected.
Restore default iterator destruction. Callers that need to continue
writing can use `iterator({ destroyOnReturn: false })`.
Assisted-by: Codex
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Collaborator
|
Review requested:
|
mcollina
changed the title
nodejs-github-bot
added
needs-ci
mcollina
changed the title
ronag
approved these changes
Sep 11, 2026
Member
Author
|
cc @trevnorris |
Contributor
|
Excellent. Thank you! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65986 +/- ##
==========================================
- Coverage 90.17% 90.16% -0.01%
==========================================
Files 771 771
Lines 265451 265480 +29
Branches 50459 50454 -5
==========================================
+ Hits 239361 239369 +8
+ Misses 17059 17056 -3
- Partials 9031 9055 +24
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async iteration left the writable side of
allowHalfOpenduplexes open after clean EOF. Fornet.Socketinstances, this retained a live handle after the peer disconnected.Restore default iterator destruction. Callers that need to continue writing can use
iterator({ destroyOnReturn: false }).Fixes: #65110