deps: V8: cherry-pick 383a6d80e857 - #65989
Open
avivkeller wants to merge 2 commits into
Open
Conversation
Original commit message:
[inspector] Fix instrumentation breakpoint on wrapped scripts
SetInstrumentationBreakpoint iterates the SFIs in a Script and picks
the toplevel SFI to attach the instrumentation breakpoint to. For
scripts compiled via ScriptCompiler::CompileFunction (e.g. Node.js CJS
modules), the resulting Script contains two SFIs: a synthetic toplevel
that just returns the wrapped function, and the wrapped SFI that the
embedder actually invokes. Picking the toplevel for such a script
means the breakpoint never fires when execution enters the user's
code.
Select the wrapped SFI for wrapped Scripts so that the breakpoint is
attached where execution will actually pause.
Bug: 516452552
Change-Id: I424c709655a6d5809d527f19f90dfb89e8acb7a8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7883039
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107643}
Refs: v8/v8@383a6d8
Signed-off-by: Aviv Keller <me@aviv.sh>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65989 +/- ##
==========================================
+ Coverage 89.98% 90.04% +0.05%
==========================================
Files 784 784
Lines 268263 268361 +98
Branches 51102 51141 +39
==========================================
+ Hits 241401 241644 +243
+ Misses 17426 17253 -173
- Partials 9436 9464 +28 🚀 New features to boost your workflow:
|
aduh95
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@383a6d8
Fixes: #31138
Ref: #31138 (comment)