util: fix TextEncoder.encodeInto underfilling - #65997
Open
XadillaX wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
c++
XadillaX
force-pushed
the
fix-textencoder-encodeinto-underfill
branch
from
September 12, 2026 06:30
8afb2c6 to
6417dc3
Compare
Correct the two-byte UTF-8 boundary and keep Latin-1 input unsigned while finding the prefix that fits. Handle surrogate pairs atomically in the scalar tail. Use replacement-aware UTF-16 sizing and validate during conversion so valid input avoids a separate validation pass. Fixes: nodejs#65994 Signed-off-by: XadillaX <i@2333.moe>
XadillaX
force-pushed
the
fix-textencoder-encodeinto-underfill
branch
from
September 12, 2026 06:47
6417dc3 to
fe02f30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextEncoder.encodeInto()could underfill narrow destination buffers on the optimized path because:charwhile calculating the scalar tail.Keep one-byte input unsigned, use the correct UTF-8 boundary, and account for surrogate pairs atomically. Use replacement-aware UTF-16 sizing and validate during conversion, avoiding a separate validation pass for valid input. A TODO records the preferred future simdutf bounded-conversion API that would return both consumed and written counts.
Fixes: #65994