Always add parentheses around regex pattern in generated SQL

[fritz3n]

Fixes #3923

[Copilot]

Copilot review overview

🟡 Changes recommended

The Singleline non-constant branch still omits parentheses, and JSON-derived pattern regression coverage is missing.

Review effort: Lite
Findings: 1

Open (1)

• Parenthesize non-constant regex patterns with JSON traversal · New

What changed in this PR

Updates PostgreSQL regex SQL generation to parenthesize dynamic patterns and refresh affected SQL baselines.

Changes:

• Groups non-constant regex patterns in generated SQL.
• Updates column- and parameter-pattern baselines.

File	Summary
test/​EFCore.PG.FunctionalTests/​Query/​Translations/​StringTranslationsNpgsqlTest.cs	Updates regex SQL baseline; lacks JSON-derived pattern coverage.
test/​EFCore.PG.FunctionalTests/​Query/​NorthwindFunctionsQueryNpgsqlTest.cs	Updates parameter-pattern baseline.
src/​EFCore.PG/​Query/​Internal/​NpgsqlQuerySqlGenerator.cs	Adds grouping for dynamic regex patterns; a non-constant Singleline branch remains ungrouped.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

Update the affected SQL baselines and add coverage for JSON-derived regex patterns.

Review effort: Lite
Findings: 1

Open (1)

• Update AssertSql baselines for changed regex SQL · New

Resolved since last review (1)

• Parenthesize non-constant regex patterns with JSON traversal

[Copilot]

Copilot review overview

🔵 Needs a closer look

Add regression coverage for expression-based patterns, including the non-constant single-line path.

Review effort: Lite
Findings: 1

Open (1)

• Update AssertSql baselines for changed regex SQL

Previously missed (1)

In code that hasn't changed since last review

Add regression coverage for JSON traversal regex patterns

test/​EFCore.PG.FunctionalTests/​Query/​NorthwindFunctionsQueryNpgsqlTest.cs:104

The updated assertions only exercise a plain column and a parameter, so they do not cover the precedence-sensitive case this PR fixes: a pattern expression such as a JSON traversal (json_column ->> 'a'). Please add a regression test that would fail with the old ('(?p)' || pattern) SQL; the new RegexOptions.Singleline non-constant path is also currently only tested with a literal pattern.