Repository navigation
Conversation
lforchini
added this pull request to stack #95
October 15, 2026 11:20
lforchini
force-pushed
the
bugfix/stop-backend-util-report
branch
4 times, most recently
from
October 15, 2026 11:58
798ca75 to
dcb6572
Compare
lforchini
marked this pull request as ready for review
October 15, 2026 11:59
lforchini
removed this pull request from stack #95
October 21, 2026 08:27
tmakatos
reviewed
Oct 21, 2026
tmakatos
left a comment
tmakatos
left a comment
Collaborator
There was a problem hiding this comment.
By "bypassing" do you mean trigger scale ups/downs?
lforchini
added this pull request to stack #152
October 23, 2026 08:22
lforchini
force-pushed
the
bugfix/stop-backend-util-report
branch
from
October 23, 2026 08:24
dcb6572 to
104c4cd
Compare
Fixes #89, #90 The controller constructs a struct from tracking mutable state and backend collected performance counters which it then passes to the engine. Previously the engine was given a reference to the Instance itself, potentially allowing the engine to bypass the controller. Now, only the controller can command the Instance with the engine advising the controller. This split also makes testing easier. Instead of having to construct full Instances, now only fake data needs to be passed to the engine to evaluate its decisions. Also, the controller now derives thread count and utilisation from procfs instead of relying on the backend. Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com> Co-authored-by: Cursor <cursoragent@cursor.com>
lforchini
force-pushed
the
bugfix/stop-backend-util-report
branch
from
October 23, 2026 08:40
104c4cd to
18af41d
Compare
lforchini
removed this pull request from stack #152
October 23, 2026 08:44
lforchini
added this pull request to stack #157
October 23, 2026 08:45
lforchini
removed this pull request from stack #157
October 23, 2026 08:49
lforchini
added this pull request to stack #159
October 23, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89, Fixes #90
The controller constructs a struct from tracking mutable state and
backend collected performance counters which it then passes to the
engine. Previously the engine was given a reference to the Instance
itself, potentially allowing the engine to bypass the controller. Now,
only the controller can command the Instance with the engine advising
the controller.
This split also makes testing easier. Instead of having to construct
full Instances, now only fake data needs to be passed to the engine to
evaluate its decisions.
Also, the controller now derives thread count and utilisation from
procfs instead of relying on the backend.
Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬