Repository navigation
Conversation
In some instances, a prefix could be appended twice. Some config loading functions would take a `util::Path` (prefixed), convert it to a `std::*::Path` (still prefixed), and then convert it to a `util::Path` again, doubling the prefix. Don't perform this intermediate step, directly append to the `util::Path`. Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
lforchini
added this pull request to stack #157
October 23, 2026 08:45
lforchini
removed this pull request from stack #157
October 23, 2026 08:49
lforchini
added this pull request to stack #159
October 23, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some instances, a prefix could be appended twice. Some config
loading functions would take a
util::Path(prefixed), convert it to astd::*::Path(still prefixed), and then convert it to autil::Pathagain, doubling the prefix. Don't perform this intermediate step,
directly append to the
util::Path.Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬