Repository navigation
Conversation
lforchini
added this pull request to stack #83
October 1, 2026 14:37
lforchini
force-pushed
the
test/refactor-config-loading
branch
from
October 1, 2026 14:48
74da0ec to
703d3ea
Compare
lforchini
removed this pull request from stack #83
October 1, 2026 14:50
lforchini
added this pull request to stack #84
October 1, 2026 14:50
lforchini
force-pushed
the
test/refactor-config-loading
branch
from
October 5, 2026 08:10
703d3ea to
91e6361
Compare
lforchini
removed this pull request from stack #84
October 5, 2026 08:12
lforchini
added this pull request to stack #87
October 5, 2026 08:16
lforchini
marked this pull request as ready for review
October 5, 2026 08:25
lforchini
force-pushed
the
test/refactor-config-loading
branch
from
October 5, 2026 08:50
91e6361 to
8edfe60
Compare
lforchini
force-pushed
the
test/refactor-config-loading
branch
from
October 8, 2026 07:30
8edfe60 to
9c5ecd0
Compare
lforchini
removed this pull request from stack #87
October 8, 2026 15:22
lforchini
force-pushed
the
test/refactor-config-loading
branch
from
October 8, 2026 15:23
9c5ecd0 to
ecb32ff
Compare
lforchini
added this pull request to stack #88
October 8, 2026 15:23
lforchini
removed this pull request from stack #88
October 13, 2026 12:32
lforchini
force-pushed
the
test/refactor-config-loading
branch
from
October 13, 2026 12:43
ecb32ff to
afac66f
Compare
lforchini
added this pull request to stack #95
October 13, 2026 12:44
lforchini
force-pushed
the
test/refactor-config-loading
branch
from
October 13, 2026 13:17
afac66f to
f1b373f
Compare
lforchini
force-pushed
the
test/refactor-config-loading
branch
2 times, most recently
from
October 13, 2026 14:02
c353351 to
31314b7
Compare
tmakatos
reviewed
Oct 21, 2026
tmakatos
left a comment
tmakatos
left a comment
Collaborator
There was a problem hiding this comment.
Can you explain what problem the refactor solves?
Collaborator
Author
|
Sure, there's two separate bugs: one is that it would apply the prefix mechanism twice, and secondly I consolidated the three config loading mechanisms into a single one that falls back onto a default config if it's not found. addressing this todo: |
lforchini
removed this pull request from stack #95
October 21, 2026 08:27
Instead of having three separate implementations of 'try to load, use default if ENOENT', introduce a canonical config loading function. Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
lforchini
added this pull request to stack #152
October 23, 2026 08:22
lforchini
force-pushed
the
test/refactor-config-loading
branch
from
October 23, 2026 08:24
31314b7 to
82c32e8
Compare
lforchini
force-pushed
the
test/refactor-config-loading
branch
from
October 23, 2026 08:39
82c32e8 to
e3d51c4
Compare
lforchini
removed this pull request from stack #152
October 23, 2026 08:44
lforchini
added this pull request to stack #157
October 23, 2026 08:45
lforchini
removed this pull request from stack #157
October 23, 2026 08:49
lforchini
added this pull request to stack #159
October 23, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where the
util::Pathprefix was appended twice in somecases, and also consolidated config loading into a single function.
It attempts to read the config file and falls back the a default
implementation if not found.
Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬