Repository navigation
Conversation
lforchini
added this pull request to stack #83
October 1, 2026 14:37
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 1, 2026 14:48
8423944 to
5536c47
Compare
lforchini
removed this pull request from stack #83
October 1, 2026 14:50
lforchini
added this pull request to stack #84
October 1, 2026 14:50
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 1, 2026 15:00
5536c47 to
3b44bfe
Compare
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 5, 2026 08:10
3b44bfe to
2c4de8d
Compare
lforchini
removed this pull request from stack #84
October 5, 2026 08:12
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 5, 2026 08:15
2c4de8d to
229632d
Compare
lforchini
added this pull request to stack #87
October 5, 2026 08:16
lforchini
force-pushed
the
test/ctest-controller
branch
2 times, most recently
from
October 5, 2026 08:55
1f746b3 to
50086c5
Compare
lforchini
marked this pull request as ready for review
October 5, 2026 08:55
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 5, 2026 09:16
50086c5 to
f78d872
Compare
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 8, 2026 07:30
f78d872 to
173188f
Compare
lforchini
removed this pull request from stack #87
October 8, 2026 15:22
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 8, 2026 15:23
173188f to
8aeacce
Compare
lforchini
added this pull request to stack #88
October 8, 2026 15:23
lforchini
removed this pull request from stack #88
October 13, 2026 12:32
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 13, 2026 12:43
8aeacce to
8174468
Compare
lforchini
added this pull request to stack #95
October 13, 2026 12:44
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 13, 2026 13:17
8174468 to
ee20f3d
Compare
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 13, 2026 13:29
ee20f3d to
f963834
Compare
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 13, 2026 14:02
f963834 to
5a95063
Compare
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 13, 2026 14:06
5a95063 to
c10c35a
Compare
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 14, 2026 11:19
c10c35a to
e04d4bd
Compare
tmakatos
reviewed
Oct 21, 2026
| path.write_text(json.dumps(payload)) | ||
|
|
||
|
|
||
| class FakeBackend: |
Collaborator
There was a problem hiding this comment.
IMO the FakeBackend should be added with the relevant Rust code.
| self.default_vm = DEFAULT_VM | ||
| self.add_vm(DEFAULT_VM) | ||
|
|
||
| def add_vm(self, vm_id, **fields): |
Collaborator
There was a problem hiding this comment.
Can you document functions?
| @@ -0,0 +1,180 @@ | |||
| # SPDX-License-Identifier: BSD-3-Clause | |||
Collaborator
There was a problem hiding this comment.
IMO the tests should come in a separate commit.
|
|
||
|
|
||
| def test_actuation_enforces_vcpu_cap(controller, fake_backend, run_threshold, fast_threshold): | ||
| """A managed VM's pool stays within its vCPU count.""" |
Collaborator
There was a problem hiding this comment.
I generally prefer documenting a test more explicitly, e.g. "Test that foo does such and such.", no strong feeling though.
lforchini
removed this pull request from stack #95
October 21, 2026 08:27
tmakatos
reviewed
Oct 21, 2026
|
|
||
|
|
||
| @pytest.fixture | ||
| def run_threshold(controller): |
Collaborator
There was a problem hiding this comment.
Shouldn't this be called run_controller?
tmakatos
reviewed
Oct 21, 2026
| CONTROLLER_INTERFACE = "com.nutanix.io_thread_controller1" | ||
| POLL_S = 0.2 | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Can you document what non-trivial functions do?
| self.add_vm(DEFAULT_VM) | ||
|
|
||
| def add_vm(self, vm_id, **fields): | ||
| defaults = { |
Collaborator
There was a problem hiding this comment.
Can we use a class instead and abstract the way it's written to disk so that it's more maintanable.
| path.write_text(json.dumps(payload)) | ||
|
|
||
|
|
||
| class FakeBackend: |
Collaborator
There was a problem hiding this comment.
I have a vague feeling that we might be able to use Python's mock for this, need to think about it.
| ) | ||
|
|
||
|
|
||
| class DBusServer: |
Collaborator
There was a problem hiding this comment.
Can you document a bit what's this about?
| self._proc.wait(timeout=5) | ||
|
|
||
|
|
||
| class MockProc: |
|
|
||
|
|
||
| class Controller: | ||
| """Starts ``io-thread-controller`` against the fake backend.""" |
Collaborator
There was a problem hiding this comment.
Is that the real controller it starts?
lforchini
added this pull request to stack #152
October 23, 2026 08:22
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 23, 2026 08:24
e04d4bd to
3c8cc6e
Compare
AI-Generated: Most of it Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
lforchini
force-pushed
the
test/ctest-controller
branch
from
October 23, 2026 08:39
3c8cc6e to
6d16886
Compare
lforchini
removed this pull request from stack #152
October 23, 2026 08:44
lforchini
added this pull request to stack #157
October 23, 2026 08:45
lforchini
removed this pull request from stack #157
October 23, 2026 08:49
lforchini
changed the base branch from
test/per-test-dbus
to
create-comptest-fixtures
October 23, 2026 08:50
lforchini
added this pull request to stack #159
October 23, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add component tests which ensure the controller enforces configured
limits such as vCPU cap and thread bounds. Also include the fixtures
necessary for these tests.
Signed-off-by: Leonardo Forchini leonardo.forchini@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬