fix(e2e): wait for backend to be healthy before starting ssl-offloading nginx proxy (backport of #4551) - #4554
Merged
Conversation
…ng nginx proxy nginx resolves its upstream backend's hostname once, at config load time, and never retries. With no depends_on, Docker Compose starts the proxy and its backend concurrently, so if the backend's network alias isn't registered yet, nginx crashes immediately with "host not found in upstream" and stays down. Backport of #4551 to V5.4. Only nuts-network/ssl-offloading/nginx is affected: it's the only e2e suite on this branch with the nginx-fronts-nuts-node pattern that master's fix also touched (the other suites either don't exist yet on V5.4, or predate the nginx proxy being introduced, as with openid4vci/issuer-initiated). Assisted by AI
stevenvegt
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4551 to V5.4.
V5.4 only has 2 of the 11 files master's fix touched:
nuts-network/ssl-offloading/nginxandopenid4vci/issuer-initiated. Of those, onlyssl-offloading/nginxstill has the affected nginx-fronts-nuts-node pattern —issuer-initiatedon this branch predates the nginx proxy being introduced there, so it has no nginx service to fix. The other 9 suites don't exist yet on V5.4. Scope is narrowed accordingly; not a straight cherry-pick.Assisted by AI