Repository navigation
docs(test): fix several typos - #2590
Merged
Merged
Conversation
abeldekat
added
documentation
echasnovski
requested changes
Oct 25, 2026
| case of a doubt, use `child.lua()`. | ||
| - Almost all methods use |vim.rpcrequest()| (i.e. wait for call to finish and | ||
| then return value). See for `*_notify` variant to use |vim.rpcnotify()|. | ||
| then return value). For `*_notify` variants see |vim.rpcnotify()|. |
Member
There was a problem hiding this comment.
This changes the meaning, though. The intended message is "If there is a *_notify method, it uses |vim.rpcnotify()|". If this is more understandable, then let's use it. If not, let's keep as is.
Member
Author
There was a problem hiding this comment.
Yes that's better. Would you consider:
In a `*_notify` variant |vim.rpcnotify()| is used.
Member
There was a problem hiding this comment.
Sure, sounds good as long as it fits the same line (which it does).
Member
Indeed it is not quite |
abeldekat
force-pushed
the
mini_docs_test
branch
from
October 25, 2026 10:03
2a4e50b to
9b125e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst reading both docs and code, I found some typos.
There is a part I found confusing:
It does not execute
vim.api.nvim_buf_line_count(0)literally. Perhaps: