Repository navigation
Store seed || pubkey for generated Ed25519 keys - #45
Merged
Merged
Conversation
PrivateKey::new stored only the 32-byte seed, which OpenSSH rejects as an invalid format. Store the 64-byte seed || public key form that OpenSSH expects and that the parser already produces.
timweri
changed the title
seed || pubkey for generated Ed25519 keys
timweri
marked this pull request as ready for review
September 23, 2026 22:02
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation and tests address the key-format issue with no unresolved concerns.
Review effort: Balanced
Findings: None
What changed in this PR
Updates generated Ed25519 private keys to use OpenSSH’s required 64-byte seed || public key representation.
Changes:
- Stores the public key alongside the generated seed.
- Adds round-trip serialization and signature verification tests.
| File | Description |
|---|---|
tests/privkey.rs |
Tests key layout, round-tripping, and signing. |
src/ssh/privkey.rs |
Generates OpenSSH-compatible Ed25519 private key material. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
timweri
added
the
conformance
obelisk
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flagged by Opus 5.5:
PrivateKey::newstored only the 32-byte seed, which OpenSSH rejects as an invalid format. Store the32-byte seed || public keyform that OpenSSH expects and that the parser already produces.