Skip to content

fix(dr-egeria): add missing ISC Qualified Name to Link Product Dependency (ISSUE-109) - #386

Merged
dwolfson merged 1 commit into
odpi:mainfrom
dwolfson:fix/link-product-dependency-isc-qualified-name
Sep 21, 2026
Merged

dwolfson merged 1 commit into
odpi:mainfrom
dwolfson:fix/link-product-dependency-isc-qualified-name

Conversation

@dwolfson

Copy link
Copy Markdown
Member

Summary

Follow-up to #376. Mandy Chessell approved that PR's Link Product Dependency template fix but asked directly whether ISC Qualified Name was still unmapped — it was, and the earlier "correctly absent, not a bug" conclusion in #376 was wrong. It was checked against a stale local .http copy (pyegeria/http clients/Egeria-api-product-manager.http, gitignored and user-managed, no drift signal). Re-checked against current upstream odpi/egeria source directly: DigitalProductDependencyProperties now extends LineageRelationshipProperties (which declares iscQualifiedName) rather than being a flat label/description-only class — a real upstream shape change the local copy predates.

  • Added ISC Qualified Name (level Advanced) to the Digital Product Dependency bundle, copying the identical, pre-existing attribute definition from the Lineage Linker family (shared-attribute convention, not reinvented).
  • Wired iscQualifiedName into the DigitalProductDependencyProperties body in collection_manager_processor.py.
  • Regenerated templates — the field now appears in the Advanced template only, matching its declared level (correctly absent from Basic).
  • Logged as ISSUE-109 in PYEGERIA_ISSUES.md, including the lesson about re-checking against raw.githubusercontent.com/odpi/egeria/main/... directly when a domain expert questions a "confirmed not a bug" conclusion, rather than re-trusting the same stale local copy.

Test plan

  • New test test_link_product_dependency_sends_isc_qualified_name in tests/micro-tests/test_collection_link_multilink_guid.py
  • pytest tests/micro-tests/ — full suite passes
  • Verified via the Spec Editor's POST /api/validate/{family} — no structural findings
  • Confirmed the two ISC Qualified Name attribute definitions (Digital Products, Lineage Linker) are byte-identical, avoiding the compact-JSON global-namespace divergence risk

🤖 Generated with Claude Code

…ency (ISSUE-109)

Mandy Chessell approved the earlier Link Product Dependency template fix
(odpi#376) but questioned whether ISC Qualified Name was still unmapped. It
was -- and the earlier "correctly absent, not a bug" conclusion in odpi#376 was
wrong, not because the reasoning was bad but because it was checked against
a stale local .http copy. Re-checked against current upstream odpi/egeria
source directly: DigitalProductDependencyProperties now extends
LineageRelationshipProperties (which declares iscQualifiedName) rather than
being a flat label/description-only class.

Added ISC Qualified Name (level Advanced) to the Digital Product Dependency
bundle, copying the identical, pre-existing attribute definition from the
Lineage Linker family per this repo's shared-attribute convention. Wired
iscQualifiedName into the DigitalProductDependencyProperties body in
collection_manager_processor.py. Regenerated templates confirm it now
appears in the Advanced template only, matching its declared level.

New test: test_link_product_dependency_sends_isc_qualified_name in
tests/micro-tests/test_collection_link_multilink_guid.py. Full
tests/micro-tests/ suite verified green.

Logs ISSUE-109 in PYEGERIA_ISSUES.md, including the lesson: this repo's
gitignored, user-managed pyegeria/http clients/ directory has no signal
when it drifts from upstream -- when a domain expert questions a "confirmed
not a bug" conclusion, re-check against raw.githubusercontent.com/odpi/
egeria/main/... directly rather than re-trusting the same local copy that
produced the wrong answer.

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
@dwolfson
dwolfson merged commit dd90038 into odpi:main Sep 21, 2026
5 checks passed
@dwolfson
dwolfson deleted the fix/link-product-dependency-isc-qualified-name branch September 21, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant