fix(dr-egeria): add missing ISC Qualified Name to Link Product Dependency (ISSUE-109) - #386
Merged
dwolfson merged 1 commit intoSep 21, 2026
Conversation
…ency (ISSUE-109) Mandy Chessell approved the earlier Link Product Dependency template fix (odpi#376) but questioned whether ISC Qualified Name was still unmapped. It was -- and the earlier "correctly absent, not a bug" conclusion in odpi#376 was wrong, not because the reasoning was bad but because it was checked against a stale local .http copy. Re-checked against current upstream odpi/egeria source directly: DigitalProductDependencyProperties now extends LineageRelationshipProperties (which declares iscQualifiedName) rather than being a flat label/description-only class. Added ISC Qualified Name (level Advanced) to the Digital Product Dependency bundle, copying the identical, pre-existing attribute definition from the Lineage Linker family per this repo's shared-attribute convention. Wired iscQualifiedName into the DigitalProductDependencyProperties body in collection_manager_processor.py. Regenerated templates confirm it now appears in the Advanced template only, matching its declared level. New test: test_link_product_dependency_sends_isc_qualified_name in tests/micro-tests/test_collection_link_multilink_guid.py. Full tests/micro-tests/ suite verified green. Logs ISSUE-109 in PYEGERIA_ISSUES.md, including the lesson: this repo's gitignored, user-managed pyegeria/http clients/ directory has no signal when it drifts from upstream -- when a domain expert questions a "confirmed not a bug" conclusion, re-check against raw.githubusercontent.com/odpi/ egeria/main/... directly rather than re-trusting the same local copy that produced the wrong answer. Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #376. Mandy Chessell approved that PR's
Link Product Dependencytemplate fix but asked directly whetherISC Qualified Namewas still unmapped — it was, and the earlier "correctly absent, not a bug" conclusion in #376 was wrong. It was checked against a stale local.httpcopy (pyegeria/http clients/Egeria-api-product-manager.http, gitignored and user-managed, no drift signal). Re-checked against current upstreamodpi/egeriasource directly:DigitalProductDependencyPropertiesnowextends LineageRelationshipProperties(which declaresiscQualifiedName) rather than being a flatlabel/description-only class — a real upstream shape change the local copy predates.ISC Qualified Name(levelAdvanced) to theDigital Product Dependencybundle, copying the identical, pre-existing attribute definition from the Lineage Linker family (shared-attribute convention, not reinvented).iscQualifiedNameinto theDigitalProductDependencyPropertiesbody incollection_manager_processor.py.PYEGERIA_ISSUES.md, including the lesson about re-checking againstraw.githubusercontent.com/odpi/egeria/main/...directly when a domain expert questions a "confirmed not a bug" conclusion, rather than re-trusting the same stale local copy.Test plan
test_link_product_dependency_sends_isc_qualified_nameintests/micro-tests/test_collection_link_multilink_guid.pypytest tests/micro-tests/— full suite passesPOST /api/validate/{family}— no structural findingsISC Qualified Nameattribute definitions (Digital Products, Lineage Linker) are byte-identical, avoiding the compact-JSON global-namespace divergence risk🤖 Generated with Claude Code