Conversation
…s (ISSUE-110) _async_initiate_survey() hard-coded its POST body to just the action-type qualified name and a single serverToSurvey action target, so finalAnalysisStep/ignoreAnalysisSteps/analysisLevel (and any other survey request parameter) could not be passed through any of the initiate_*_survey convenience wrappers - only by bypassing them and calling initiate_gov_action_type() directly. Add an optional request_parameters dict to _async_initiate_survey() and thread it into the body via body_slimmer (mirroring _async_initiate_gov_action_type's existing pattern), and add the same optional parameter to every initiate_*_survey wrapper (postgres_database/server, file_folder, file, kafka_server, uc_server, uc_schema). Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_async_initiate_survey()inpyegeria/omvs/automated_curation.pyhard-coded its POST body to just the action-type qualified name and a singleserverToSurveyaction target, sofinalAnalysisStep/ignoreAnalysisSteps/analysisLevelcouldn't be passed through anyinitiate_*_surveyconvenience wrapper.request_parameters: dict = Noneto_async_initiate_survey(), threaded into the body viabody_slimmer(mirroring_async_initiate_gov_action_type's existing pattern).initiate_*_surveywrapper:initiate_postgres_database_survey,initiate_postgres_server_survey,initiate_file_folder_survey,initiate_file_survey,initiate_kafka_server_survey,initiate_uc_server_survey,initiate_uc_schema_survey.None, existing callers unaffected.Test plan
pytest tests/micro-tests -m unit— all green, no regressions.🤖 Generated with Claude Code