Repository navigation
Welcome page: detailed map and full city list on by default - #41
Merged
Merged
Conversation
Both switches on the welcome page start on. Nothing reaches the network until Start is tapped with them still on, which is the opt-in; Skip and offline mode apply neither, and a later visit shows the current settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: on the welcome page, "Detailed map" and "Full city list" started off, and flipping either one on reached the network straight away.
After: on a first run both start switched on. Tapping "Get started" with them still on turns on the detailed map and downloads the full city list (about 17 MB). Either can be switched off first. "Skip" applies neither, and in offline mode nothing is turned on. When the welcome page is opened again later, its switches show and change the current settings as before.
The privacy rule still holds: nothing reaches the network until the newcomer taps "Get started" with both switches in view, and that tap is the opt-in.
How:
IntroScreenkeeps the two choices in local state on a first run and applies them instart(). New tests intests/unit/introDefaults.spec.tsx. Typecheck and all 704 unit tests pass locally.