Repository navigation
Release 0.4.0: fix the macOS and Windows build and the AppImage test - #27
Merged
Merged
Conversation
ActionFields.tsx sat beside actionFields.ts, and RuleNotes.tsx beside ruleNotes.ts. On macOS and Windows, whose file systems ignore case, `./ActionFields` found actionFields.ts first, which exports no component, so the Release workflow's build failed there while Linux (and CI) passed. actionFields.ts becomes ruleActionFields.ts, after RULE_ACTION_FIELDS, and ruleNotes.ts becomes ruleNotesFor.ts, its function ruleNotesFor.
4 tasks done
The Linux test job installs the .deb, then updates the AppImage on the same runner. Since the app leaves the desktop to a package's entry, the AppImage saw the .deb's /usr/share/applications/console-editor.desktop, installed none of its own, and the update test timed out waiting for it on Linux x64 and arm64. The .deb step now removes the package once its own test passes, and checks its desktop entry went with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Two fixes found by running the Release workflow for 0.4.0. Neither changes anything a user of 0.3.0 would see, so the CHANGELOG is unchanged. 0.4.0 has no release, draft or tag yet. Both commits continue
release/0.4.0after its version commit, as CONTRIBUTING › Releasing step 3 describes for a failed run.1. The macOS and Windows build (
fc59921)Run 14 failed to build on macOS and Windows:
The rule form's folder has two pairs of files whose names differ only in case:
ActionFields.tsxsits besideactionFields.ts;RuleNotes.tsxsits besideruleNotes.ts.On a file system that ignores case,
./ActionFieldsfindsactionFields.tsfirst. That file exports no component, so the build breaks. Linux, and so CI, only ever saw the.tsxfiles.The fix renames the two helpers:
actionFields.tsbecomesruleActionFields.ts, named after theRULE_ACTION_FIELDSit holds;ruleNotes.tsbecomesruleNotesFor.ts, with its function renamed to match.olehwebdev/console-editor#28 adds a
lint:structurecheck so this is caught on every pull request.2. The AppImage update test (
9deba18)Run 15 built everything and passed every install test but one: "Update the AppImage" failed on Linux x64 and arm64 with:
The Linux test job installs the
.debfirst, then updates the AppImage on the same runner. Since8113375, the app leaves the desktop to an installed package's entry (SPEC §10). So the AppImage saw the.deb's/usr/share/applications/console-editor.desktopand, as designed, installed none of its own. The last time the Linux test jobs ran was for 0.3.0, before that change, so this is the first release to meet it.The
.debstep now:dpkg-deb -f <deb> Package);The AppImage is then tested as a user who has only the AppImage. The SPEC's release-workflow paragraph says so.
How it was tested
Build fix:
f2059a7,electron-vite buildthen fails with the same twoMISSING_EXPORTerrors as the macOS and Windows jobs. The fixed tree builds..debtests passed.Checks:
npm run typecheck,lint:fsd,lint:structure,lint,lint:unused,lint:duplicatesandlint:secretspass.npm testpasses (1,171), and so doesxvfb-run -a npm run test:e2e(109).Workflow fix:
dpkg-deb -f <deb> Packageprints the package's name, checked on a throwaway package.Checklist
main: therelease/0.4.0branch, fixing its releasenpm run typecheck,npm run lint:fsd,npm run lint:structure,npm run lint,npm run lint:unused,npm run lint:duplicates,npm run lint:secrets,npm testandnpm run test:e2epassdocs/SPEC.mddescribes any behaviour this changes (the release workflow's.debstep)[Unreleased]inCHANGELOG.md(none: the code was never released)Releasing (for the maintainer)
9deba18(run 16).mainalready has this branch's earlier commits, so GitHub asks you to update the branch. Use Update branch (not rebase), and don't draft again.git ls-remote --tags origin v0.4.0prints nothing, then publish the draft.