Repository navigation
AGX correctness series — fast-track for upstream submission - #2
Closed
joshuaswarren wants to merge 10000 commits into
Closed
joshuaswarren wants to merge 10000 commits into
joshuaswarren wants to merge 10000 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGX correctness series — fast-track for upstream submission
Six patches, stock-main only, no perf-only changes, no internal receipts: the correctness subset of the [Honeykrisp integration PR](PR # (integration branch, opened alongside)) that Dj asked to have upstreamed, prepared per the agreed sequencing ("send the ubfe mod-32 correctness fix first; hold cooperative-matrix commits until the correctness work is through").
agx: keep the mod-32 shift count when fusing ushr+iand into ubfe— wrong-results fixagx: represent the fused shift-then-mask as ubfe, not ubitfield_extractagx: correctly rounded fdiv/frcp, faithful log/log2, exact sin/cos reductionagx: lower the fdiv that int64 lowering and the perspective divide emit lateagx: handle flush-to-zero in precise fp32 division, log and sinenir: pass FP_MATH_CTRL to the builder generator— affects every Mesa driver, not just AGX: the builder generator droppedFP_MATH_CTRL, so any driver using it compiled with wrong fast-math settingsIntended flow: merge or cherry-pick to freedesktop
mesa/main(an MR-readyformat-patchseries is atjoshuaswarren/mesa:upstream/correctness). The full Honeykrisp integration PR will rebase after this lands.All six verified on Apple M1 hardware (t8103) against the mlx-omarchy regression battery — the same commits that carry the pinned-inference results the team publishes.