Repository navigation
Conversation
Add an internal mapped startup transition with explicit capability ceilings and exact UID/GID and supplementary group authority. Reuse the bounded mapped waiter and trusted sandbox setup, then execute from a locked nonleader thread through a raw descriptor-close/exec-or-exit tail. Preserve ordinary drop-all behavior and reject unqualified credential, environment and architecture combinations. Keep pointer-bearing syscall arguments alive across Go stack growth and compare exact group membership independently of host mapping order. Add repeated actual-production-binary authority and failure proofs, sparse GID and stack-relocation regressions, and a Changie fragment. Public mapped execution remains inhibited pending the remaining E/F/G proofs.
Code Review ✅ Approved🔴 High risk · The new mapped startup transition changes process credentials, groups, and capability authority; a faulty transition could leave an application with unintended privileges. Adds an internal mapped startup transition with explicit capability ceilings and exact UID/GID and supplementary group authority, executing from a locked nonleader thread via a raw descriptor-close/exec-or-exit tail. No issues found. VerificationRules No rules evaluated Functional validation Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
|
PR-cycle state — maintained automatically. Do not edit by hand. Mechanical PR-cycle state (JSON){
"approval": {
"candidate_revision_fingerprint": "sha256:46f011095539b9fbcfbc6bb29bd73469341e46916fd3c0162ff27422ac14d382",
"evidence": {
"attestations": [],
"candidate_revision_fingerprint": "sha256:46f011095539b9fbcfbc6bb29bd73469341e46916fd3c0162ff27422ac14d382",
"check_conclusions": [
{
"conclusion": "SUCCESS",
"name": "Bash native evidence checks",
"run_id": 123208240302,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123208240302,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 123194065131
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 123196712832
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 123204387562,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204387562,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 123204386347,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204386347,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 123204387990,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204387990,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 123204428017,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204428017,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 123204387172,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204387172,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 123204428047,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204428047,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 123204440087,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204440087,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"operation_identity": "sha256:c1cdf8f9930dda6052dfc61dfe4764c1805547c9a5b167da734f899bedcb598a",
"review_request": {
"body_digest": "sha256:a3e5fbc2db6deb01bbd53c59989538b9cf53caab3caa517ea8ee8d5910072b03",
"id": 6484914567
},
"review_result": {
"body_digest": "sha256:da60b812d3a7fa35e48068106ae40b4171d41c21325b14a1427ac495350c7da1",
"id": 6484937746
}
},
"evidence_fingerprint": "sha256:16f2e076cddebc7244bf937e259c29e4fd53467d5101dfc04f131bf9f705c099",
"head_sha": "4d219abf3d30cce50caedd8b337a160e8456b4ad",
"operation_identity": "sha256:c1cdf8f9930dda6052dfc61dfe4764c1805547c9a5b167da734f899bedcb598a",
"review_request_id": 6484914567,
"review_result_id": 6484937746,
"status": "approved-evidence-recorded"
},
"candidate_revision_fingerprint": "sha256:46f011095539b9fbcfbc6bb29bd73469341e46916fd3c0162ff27422ac14d382",
"check_conclusions": [
{
"conclusion": "SUCCESS",
"name": "Bash native evidence checks",
"run_id": 123208240302,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123208240302,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 123194065131
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 123196712832
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 123204387562,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204387562,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 123204386347,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204386347,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 123204387990,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204387990,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 123204428017,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204428017,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 123204387172,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204387172,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 123204428047,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204428047,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 123204440087,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204440087,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
}
],
"check_observations": [
{
"checks": [
{
"conclusion": "SUCCESS",
"name": "Bash native evidence checks",
"run_id": 123208240302,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123208240302",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123208240302,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 123194065131,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/runs/123194065131"
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 123196712832,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/runs/123196712832"
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 123204387562,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123204387562",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204387562,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 123204386347,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123204386347",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204386347,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 123204387990,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123204387990",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204387990,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 123204428017,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123204428017",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204428017,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 123204387172,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123204387172",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204387172,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 123204428047,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123204428047",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204428047,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 123204440087,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123204440087",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110584560860,
"event": "pull_request",
"job_id": 123204440087,
"name_unique": true,
"run_id": 40796473315,
"workflow_id": 302865520
}
}
],
"head_sha": "4d219abf3d30cce50caedd8b337a160e8456b4ad",
"id": "sha256:69848479b56535e77f02deb43de2cdae7fe1a7a631b9ef9d03a10a81b2bf2e17",
"required_checks": [
"Bash native evidence checks",
"Gitar",
"Linux CI checks",
"Target smoke (darwin-amd64)",
"Target smoke (darwin-arm64)",
"Target smoke (linux-amd64)",
"Target smoke (linux-arm64)",
"Windows host smoke (windows-amd64)",
"Windows host smoke (windows-arm64)"
],
"status": "success"
},
{
"checks": [
{
"name": "Bash native evidence checks",
"reason": "missing",
"status": "pending"
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 123194065131,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/runs/123194065131"
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 123196712832,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/runs/123196712832"
},
{
"name": "Linux CI checks",
"run_id": 123194043051,
"run_status": "in_progress",
"status": "pending",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123194043051"
},
{
"conclusion": "FAILURE",
"name": "Target smoke (darwin-amd64)",
"run_id": 123194043148,
"run_status": "completed",
"status": "failure",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123194043148"
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 123194043138,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123194043138"
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 123194043422,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123194043422"
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 123194043600,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123194043600"
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 123194043356,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123194043356"
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 123194043341,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40796473315/job/123194043341"
}
],
"head_sha": "4d219abf3d30cce50caedd8b337a160e8456b4ad",
"id": "sha256:fb5b950e776a12c219fbed1b024f02fb3cc81d5f96c371cb8c2bc4bf593712cd",
"required_checks": [
"Bash native evidence checks",
"Gitar",
"Linux CI checks",
"Target smoke (darwin-amd64)",
"Target smoke (darwin-arm64)",
"Target smoke (linux-amd64)",
"Target smoke (linux-arm64)",
"Windows host smoke (windows-amd64)",
"Windows host smoke (windows-arm64)"
],
"status": "failure"
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"delivery_deferrals": [],
"findings": [],
"pr": {
"base_ref": "pr300",
"base_sha": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"body_digest": "sha256:431108654531171077077896699df79d5617a6ca260d3200bae1d71bc8685745",
"body_identity_version": 2,
"diff_digest": "sha256:96a5aeaa238d0e9ac2209e776c66b9b772864142b167a54c54c7046b9999f3e6",
"head_ref": "pr302",
"head_sha": "4d219abf3d30cce50caedd8b337a160e8456b4ad",
"pr": 302,
"repository": "omry/reploy",
"scope_authority": [
{
"digest": "sha256:078e63e84d432c2aad03120ca30e40ec4572a8970e6bf6be9d5008608a30f435",
"path": "docs/MULTI_IDENTITY_D_DESIGN.md"
},
{
"digest": "sha256:ab5e9be8075947bc37c863545efb1959fa7aca886226018729bfeff6f7032e1e",
"path": "docs/MULTI_IDENTITY_E_DESIGN.md"
},
{
"digest": "sha256:3ef44a7a0be43648f5df1faad39b16101978662c58c87d6fa8e7409093a58fe9",
"path": "docs/MULTI_IDENTITY_IMPLEMENTATION_PLAN.md"
},
{
"digest": "sha256:fe188bb8a80f7f235e99b023283749a3a9e3172e4adf70b70b495d80e50e9218",
"path": "docs/MULTI_IDENTITY_MAIL_RECONCILIATION.md"
},
{
"digest": "sha256:b049714f4a85d0f3fb204615897374377690564627bfcdd03e50c945fb042826",
"path": "docs/MULTI_IDENTITY_SECURITY_CONTRACT.md"
}
],
"title_digest": "sha256:09679971a3d9be0779beec98c200a121c5fbd6c4fc82145c8ea0fff0e127beec"
},
"record_version": 6,
"review_observations": [],
"review_requests": [
{
"base_established_at": "2026-10-29T00:48:43Z",
"base_ref": "pr300",
"base_sha": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"body_digest": "sha256:a3e5fbc2db6deb01bbd53c59989538b9cf53caab3caa517ea8ee8d5910072b03",
"created_at": "2026-10-29T01:00:30Z",
"head_sha": "4d219abf3d30cce50caedd8b337a160e8456b4ad",
"id": 6484914567,
"kind": "regular-review"
}
],
"review_results": [
{
"base_ref": "pr300",
"base_sha": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"body_digest": "sha256:da60b812d3a7fa35e48068106ae40b4171d41c21325b14a1427ac495350c7da1",
"commit_id": "4d219abf3d30cce50caedd8b337a160e8456b4ad",
"id": 6484937746,
"inline_message_ids": [],
"request_comment_id": 6484914567,
"result_kind": "clean",
"status": "result",
"submitted_at": "2026-10-29T01:02:00Z",
"unresolved_thread_ids": []
}
],
"revision_fingerprint": "sha256:46f011095539b9fbcfbc6bb29bd73469341e46916fd3c0162ff27422ac14d382",
"rounds": [
{
"applied_fix_paths": [],
"disposition_changes": [],
"effective_diff_digest": "sha256:96a5aeaa238d0e9ac2209e776c66b9b772864142b167a54c54c7046b9999f3e6",
"finding_ids": [],
"invariants": [
"Exact final startup credentials, capability ceiling, empty inheritable and ambient sets, NNP and securebits remain verified.",
"No stronger surviving Go thread across exec; fail closed after credential mutation.",
"Public mapped guards remain closed and later E/F/runtime qualification gates remain required.",
"Every exact-head ci.yml job must succeed before approval."
],
"outcome": "same-head-needs-retry",
"proposed_fix_paths": [],
"resulting_head": "4d219abf3d30cce50caedd8b337a160e8456b4ad",
"review_observation_id": null,
"review_request_id": 6484914567,
"review_result_id": 6484937746,
"reviewed_head": "4d219abf3d30cce50caedd8b337a160e8456b4ad",
"root_cause": "Remote review clean and full exact-head local validation passed. Darwin AMD64 internal/dockerdeploy exceeded aggregate Go package timeout of5m, with no assertion failure; parent package took234.241s. E2.1 changes no package source implicated by the stack. Duration increase cause remains unproved. One bounded unchanged-head failed-job retry; no source edits or synchronization.",
"round": 1,
"unresolved_current_slice_findings": 0,
"unresolved_design_blockers": 0
},
{
"applied_fix_paths": [],
"disposition_changes": [],
"effective_diff_digest": "sha256:96a5aeaa238d0e9ac2209e776c66b9b772864142b167a54c54c7046b9999f3e6",
"finding_ids": [],
"invariants": [
"Exact final startup credentials, capability ceiling, empty inheritable and ambient sets, NNP and securebits remain verified.",
"No stronger surviving Go thread across exec; fail closed after credential mutation.",
"Public mapped guards remain closed and later E/F/runtime qualification gates remain required.",
"Every exact-head ci.yml job must succeed before approval."
],
"outcome": "clean",
"proposed_fix_paths": [],
"resulting_head": "4d219abf3d30cce50caedd8b337a160e8456b4ad",
"review_observation_id": null,
"review_request_id": 6484914567,
"review_result_id": 6484937746,
"reviewed_head": "4d219abf3d30cce50caedd8b337a160e8456b4ad",
"root_cause": "Original Darwin AMD64 package aggregate timeout passed on one unchanged-head retry; all required CI jobs now succeeded, remote review is clean and fresh full local validation passed. No source correction or scope expansion. Duration increase cause remains unproved.",
"round": 2,
"unresolved_current_slice_findings": 0,
"unresolved_design_blockers": 0
}
],
"schema": "awd:swe:pr-cycle-state",
"version": 2
} |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add an internal mapped startup transition with explicit capability ceilings and exact UID/GID and supplementary group authority. Reuse the bounded mapped waiter and trusted sandbox setup, then execute from a locked nonleader thread through a raw descriptor-close/exec-or-exit tail.
Preserve ordinary drop-all behavior and reject unqualified credential, environment and architecture combinations. Keep pointer-bearing syscall arguments alive across Go stack growth and compare exact group membership independently of host mapping order. Add repeated actual-production-binary authority and failure proofs, sparse GID and stack-relocation regressions, and a Changie fragment. Public mapped execution remains inhibited pending the remaining E/F/G proofs.