Skip to content

E4.2: Qualify private mapped execution and retain conformance evidence - #317

Merged
omry merged 1 commit into
pr316from
pr317
Oct 31, 2026
Merged

omry merged 1 commit into
pr316from
pr317

Conversation

@omry

@omry omry commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

Add repeated integrated private journeys for both mapping profiles, with authority refusal, interrupted release, cancellation, owned cleanup and retained identity history. Reuse the existing production planner, lifetime and startup mechanism fixtures.

Add a local evidence collector and integrity tests that bind source, compiler, profiles and exact test results. Keep injected engine/native/F observations separate from production exec mechanism evidence and explicitly leave live-engine/OCI, F/G and public activation unqualified. No production runtime behavior changes.


@omry
omry changed the base branch from main to pr316 October 31, 2026 17:25
@omry
omry added this pull request to stack #308 October 31, 2026 17:25
@omry

omry commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:aba81fe568d2d117c70dd6f918a7c60a186d170e85d2a39a292f74459509c68f",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:aba81fe568d2d117c70dd6f918a7c60a186d170e85d2a39a292f74459509c68f",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "Bash native evidence checks",
          "run_id": 124624285136
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 124620766698
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 124620776970
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 124620777245
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 124620777133
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 124620777138
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 124620777166
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 124620777147
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 124620777288
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:38106dccc839aa4e872e3a1197c9d8566034759f3d860624693980efae21ddae",
      "operation_identity": "sha256:a4e466c02984a7919ec0ab58f9690382e3e1d03ebf673cf16d899dabf463b11a",
      "review_request": {
        "body_digest": "sha256:92be357ff558e03cdfa8ef80ca1a184253de13538a90c1b697a0b5b7b155625a",
        "id": 6547566618
      },
      "review_result": {
        "body_digest": "sha256:21af2f1ba420ee3b9df9bddc49bb76898121591ca7639b3740030e7858053622",
        "id": 6547581747
      }
    },
    "evidence_fingerprint": "sha256:fca85c31bc17445a4ce489ef14ee6ebf30a5cb821ad8ea9161e7b118aa4d808b",
    "head_sha": "87899abecced4c5f8b3513ecee66793ecdd2df37",
    "operation_identity": "sha256:a4e466c02984a7919ec0ab58f9690382e3e1d03ebf673cf16d899dabf463b11a",
    "review_request_id": 6547566618,
    "review_result_id": 6547581747,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:aba81fe568d2d117c70dd6f918a7c60a186d170e85d2a39a292f74459509c68f",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "Bash native evidence checks",
      "run_id": 124624285136
    },
    {
      "conclusion": "SUCCESS",
      "name": "Gitar",
      "run_id": 124620766698
    },
    {
      "conclusion": "SUCCESS",
      "name": "Linux CI checks",
      "run_id": 124620776970
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (darwin-amd64)",
      "run_id": 124620777245
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (darwin-arm64)",
      "run_id": 124620777133
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (linux-amd64)",
      "run_id": 124620777138
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (linux-arm64)",
      "run_id": 124620777166
    },
    {
      "conclusion": "SUCCESS",
      "name": "Windows host smoke (windows-amd64)",
      "run_id": 124620777147
    },
    {
      "conclusion": "SUCCESS",
      "name": "Windows host smoke (windows-arm64)",
      "run_id": 124620777288
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Bash native evidence checks",
          "run_id": 124624285136,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41229577277/job/124624285136"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 124620766698,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/runs/124620766698"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 124620776970,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41229577277/job/124620776970"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 124620777245,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41229577277/job/124620777245"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 124620777133,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41229577277/job/124620777133"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 124620777138,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41229577277/job/124620777138"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 124620777166,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41229577277/job/124620777166"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 124620777147,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41229577277/job/124620777147"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 124620777288,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41229577277/job/124620777288"
        }
      ],
      "head_sha": "87899abecced4c5f8b3513ecee66793ecdd2df37",
      "id": "sha256:a12e942d7b8b45b2df3f4bd72a0677694333ae8b7436a7d23e40bdadf7f88ddc",
      "required_checks": [
        "Bash native evidence checks",
        "Gitar",
        "Linux CI checks",
        "Target smoke (darwin-amd64)",
        "Target smoke (darwin-arm64)",
        "Target smoke (linux-amd64)",
        "Target smoke (linux-arm64)",
        "Windows host smoke (windows-amd64)",
        "Windows host smoke (windows-arm64)"
      ],
      "status": "success"
    },
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Bash native evidence checks",
          "run_id": 124610028207,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41224445697/job/124610028207"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 124605556165,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/runs/124605556165"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 124605553096,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41224445697/job/124605553096"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 124605553317,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41224445697/job/124605553317"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 124605553236,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41224445697/job/124605553236"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 124605553363,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41224445697/job/124605553363"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 124605553351,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41224445697/job/124605553351"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 124605553326,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41224445697/job/124605553326"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 124605553285,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41224445697/job/124605553285"
        }
      ],
      "head_sha": "3b161cc3fde9d8915376d610a71576a9d5fc5050",
      "id": "sha256:b8ca149ec3d8b9d15d51849c74a050950946ca55b8b976f503784a7e9f74529b",
      "required_checks": [
        "Bash native evidence checks",
        "Gitar",
        "Linux CI checks",
        "Target smoke (darwin-amd64)",
        "Target smoke (darwin-arm64)",
        "Target smoke (linux-amd64)",
        "Target smoke (linux-arm64)",
        "Windows host smoke (windows-amd64)",
        "Windows host smoke (windows-arm64)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [
    {
      "disposition": "verified current-slice truth fix",
      "evidence": [
        "https://github.com/omry/reploy/pull/317#discussion_r4432604687",
        "/home/omry/.local/state/awd/reploy-E-delivery-20261030/pr317-R1-GITAR-001-reproduction.json",
        "/home/omry/.local/state/awd/reploy-E-delivery-20261030/pr317-R2-full-validation.json",
        "/home/omry/.local/state/awd/reploy-E-delivery-20261030/pr317-R2-stable01-checks-result.json",
        "https://github.com/omry/reploy/pull/317#issuecomment-6547581747",
        "/home/omry/.local/state/awd/reploy-E-delivery-20261030/pr317-R1-final-correction-proof.json"
      ],
      "id": "E42-GITAR-001",
      "invariant": "Routine Go stderr must not corrupt stdout JSON; retain diagnostic stderr separately, including timeout output.",
      "proposed_fix_paths": [
        "tools/conformance/multiidentity/e_conformance.py",
        "tools/conformance/multiidentity/test_e_conformance.py",
        "tools/conformance/multiidentity/E_CONFORMANCE.md"
      ],
      "qualification": "Pending actual source correction and regression tests; no runtime behavior or authority change.",
      "resolution": "Separate JSON stdout and retained diagnostic stderr, including timeout output. Twelve regression tests and corrected collector passed. Fresh exact-head full local validation, all9 CI checks and Codex review passed.",
      "resolution_evidence": [
        "/home/omry/.local/state/awd/reploy-E-delivery-20261030/pr317-R2-full-validation.json",
        "/home/omry/.local/state/awd/reploy-E-delivery-20261030/pr317-R2-stable01-checks-result.json",
        "https://github.com/omry/reploy/pull/317#issuecomment-6547581747",
        "/home/omry/.local/state/awd/reploy-E-delivery-20261030/pr317-R1-final-correction-proof.json"
      ],
      "resolved_on_head": "87899abecced4c5f8b3513ecee66793ecdd2df37",
      "root_cause": "Both metadata command and Go test collection merge stderr into stdout before JSON parsing.",
      "source": "Gitar review thread4432604687; coordinator independently reproduced; not a Codex finding",
      "status": "resolved"
    }
  ],
  "pr": {
    "base_ref": "pr316",
    "base_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
    "body_digest": "sha256:5222339ac86fe7e9d77a028374186b949823cc87ab71c8e4d117c2ef0fa79b00",
    "body_identity_version": 2,
    "diff_digest": "sha256:8543b71f0eb30aff9e79a324db2b478de4f85d3d4269d266ae7df83dca2e89d0",
    "head_ref": "pr317",
    "head_sha": "87899abecced4c5f8b3513ecee66793ecdd2df37",
    "pr": 317,
    "repository": "omry/reploy",
    "scope_authority": [
      {
        "digest": "sha256:078e63e84d432c2aad03120ca30e40ec4572a8970e6bf6be9d5008608a30f435",
        "path": "docs/MULTI_IDENTITY_D_DESIGN.md"
      },
      {
        "digest": "sha256:f5058bb465d6af9d58b98eb6fde19edd4ed710aff1cc2588173757d37cdbbc58",
        "path": "docs/MULTI_IDENTITY_E_DESIGN.md"
      },
      {
        "digest": "sha256:3ef44a7a0be43648f5df1faad39b16101978662c58c87d6fa8e7409093a58fe9",
        "path": "docs/MULTI_IDENTITY_IMPLEMENTATION_PLAN.md"
      },
      {
        "digest": "sha256:fe188bb8a80f7f235e99b023283749a3a9e3172e4adf70b70b495d80e50e9218",
        "path": "docs/MULTI_IDENTITY_MAIL_RECONCILIATION.md"
      },
      {
        "digest": "sha256:b049714f4a85d0f3fb204615897374377690564627bfcdd03e50c945fb042826",
        "path": "docs/MULTI_IDENTITY_SECURITY_CONTRACT.md"
      }
    ],
    "title_digest": "sha256:3f8374861a209b62ca89edbfbd1493404bc910645c62d50a58a01590aca946cf"
  },
  "record_version": 6,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-10-31T17:25:19Z",
      "base_ref": "pr316",
      "base_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
      "body_digest": "sha256:fecf1ba8d5232bf61548637ac5262a1860bf9d225fd9a7d049f23cbc1ad8f7f0",
      "created_at": "2026-10-31T17:40:22Z",
      "head_sha": "3b161cc3fde9d8915376d610a71576a9d5fc5050",
      "id": 6546885092,
      "kind": "regular-review"
    },
    {
      "base_established_at": "2026-10-31T17:25:19Z",
      "base_ref": "pr316",
      "base_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
      "body_digest": "sha256:92be357ff558e03cdfa8ef80ca1a184253de13538a90c1b697a0b5b7b155625a",
      "created_at": "2026-10-31T18:39:58Z",
      "head_sha": "87899abecced4c5f8b3513ecee66793ecdd2df37",
      "id": 6547566618,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr316",
      "base_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
      "body_digest": "sha256:13fc0f0f741382f573372f5bc08c39d5d3918790949f65f3aae90a00a62c2215",
      "commit_id": "3b161cc3fde9d8915376d610a71576a9d5fc5050",
      "id": 6546899672,
      "inline_message_ids": [],
      "request_comment_id": 6546885092,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-10-31T17:41:36Z",
      "unresolved_thread_ids": [
        "PRRT_kwDOTFQCkM6yS8nL"
      ]
    },
    {
      "base_ref": "pr316",
      "base_sha": "b6627eff4b4775cd1485c45770373d15d1c665b7",
      "body_digest": "sha256:21af2f1ba420ee3b9df9bddc49bb76898121591ca7639b3740030e7858053622",
      "commit_id": "87899abecced4c5f8b3513ecee66793ecdd2df37",
      "id": 6547581747,
      "inline_message_ids": [],
      "request_comment_id": 6547566618,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-10-31T18:41:24Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:aba81fe568d2d117c70dd6f918a7c60a186d170e85d2a39a292f74459509c68f",
  "rounds": [
    {
      "applied_fix_paths": [
        "tools/conformance/multiidentity/e_conformance.py",
        "tools/conformance/multiidentity/test_e_conformance.py",
        "tools/conformance/multiidentity/E_CONFORMANCE.md",
        "internal/probe/mapped_exec_linux_test.go"
      ],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:8543b71f0eb30aff9e79a324db2b478de4f85d3d4269d266ae7df83dca2e89d0",
      "finding_ids": [
        "E42-GITAR-001"
      ],
      "invariants": [
        "Only stdout is parsed as JSON, diagnostic stderr retained with exact digest including timeout output.",
        "Deliberately destructive shared-close control must observe old-table damage independently of Go runtime fd/scheduler behavior; real production racing opener unchanged.",
        "Every final-head ci.yml job and fresh exact-head regular review must pass before approval."
      ],
      "outcome": "corrected-head-needs-review",
      "proposed_fix_paths": [
        "tools/conformance/multiidentity/e_conformance.py",
        "tools/conformance/multiidentity/test_e_conformance.py",
        "tools/conformance/multiidentity/E_CONFORMANCE.md",
        "internal/probe/mapped_exec_linux_test.go"
      ],
      "resulting_head": "87899abecced4c5f8b3513ecee66793ecdd2df37",
      "review_observation_id": null,
      "review_request_id": 6546885092,
      "review_result_id": 6546899672,
      "reviewed_head": "3b161cc3fde9d8915376d610a71576a9d5fc5050",
      "root_cause": "Collector merged stderr into JSON stdout; independently reproduced routine chatter causes JSON failure. Separate streams and retain suite/metadata stderr digests, with12 regression tests. Full validation additionally reproduced existing shared-close observer timeout1of3; test-only raw observer proved20 overlay runs and40 real exact/bounded repetitions. Full seven-command validation and corrected source-bound collector passed. No production change or timeout relaxation. Local canonical findings R1-1/R2-1/R3-1 are the same substantive observer finding; actual source retained in local review, not represented as Codex findings.",
      "round": 1,
      "unresolved_current_slice_findings": 1,
      "unresolved_design_blockers": 0
    },
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:8543b71f0eb30aff9e79a324db2b478de4f85d3d4269d266ae7df83dca2e89d0",
      "finding_ids": [],
      "invariants": [
        "JSON stdout and retained stderr diagnostics remain separated.",
        "Descriptor negative control observes shared-table damage without Go runtime descriptor dependence; production racing opener unchanged.",
        "Full local validation, exact-head all-CI success and fresh clean remote review are current.",
        "Private fixture/mechanism evidence does not qualify live F/OCI runtime or public mapped activation."
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "87899abecced4c5f8b3513ecee66793ecdd2df37",
      "review_observation_id": null,
      "review_request_id": 6547566618,
      "review_result_id": 6547581747,
      "reviewed_head": "87899abecced4c5f8b3513ecee66793ecdd2df37",
      "root_cause": "No new finding or correction in this round. Prior collector and deliberate shared-close fixture truth fixes remain verified; all9 CI checks, seven local commands and fresh Codex review passed at87899ab. Original failures and all source/evidence retained.",
      "round": 2,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry
omry marked this pull request as ready for review October 31, 2026 17:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T18:41:26.037578Z 87899ab Manual request
🔒 Security Review ⚠️ Failed 2026-10-31T17:37:51.963621Z
We couldn’t complete this review. Comment @codex security review to try again.
3b161cc Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

@omry

omry commented Oct 31, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Exact head: 3b161cc

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 3b161cc3fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Add repeated integrated private journeys for both mapping profiles, with authority refusal, interrupted release, cancellation, owned cleanup and retained identity history. Reuse the existing production planner, lifetime and startup mechanism fixtures.

Add a local evidence collector and integrity tests that bind source, compiler, profiles and exact test results. Keep injected engine/native/F observations separate from production exec mechanism evidence and explicitly leave live-engine/OCI, F/G and public activation unqualified. No production runtime behavior changes.
@gitar-bot

gitar-bot Bot commented Oct 31, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 closed / 1 findings

🟡 Medium risk · The new integrated fixtures and evidence collector add substantial test tooling; collection or parsing errors could misstate private conformance results.

Adds repeated integrated private journeys for both mapping profiles, plus a local evidence collector and integrity tests that bind source, compiler, profiles, and exact test results, with no production runtime behavior changes. Resolved the stderr merge into the JSON event log that broke parsing on routine Go output. No issues remain open.

✅ 1 closed
✅ Edge Case: stderr merged into JSON event log breaks parsing on routine go chatter

📄 tools/conformance/multiidentity/e_conformance.py:46-47 📄 tools/conformance/multiidentity/e_conformance.py:146-150 📄 tools/conformance/multiidentity/e_conformance.py:80
command() and the per-suite subprocess.run both pass stderr=subprocess.STDOUT, so anything the go tool itself writes to stderr ends up in the stream that gets parsed as JSON. That includes go: downloading <module> when the module cache is cold (go.mod has many dependencies), go: downloading go1.25.x when GOTOOLCHAIN switches toolchains, and GOFLAGS warnings. summarize() then fails on json.loads for those lines, and toolchain() fails the same way on go env -json. The result is that a clean first run on a new host reports failed/exit 1 even though every test passed. The fix is to capture stderr separately (stderr=subprocess.PIPE), keep it as its own retained artifact with its own digest, and parse only stdout as test2json events.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@omry

omry commented Oct 31, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Exact head: 87899ab

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 87899abecc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@omry omry added the approved PR reviewed and approved label Oct 31, 2026
@omry
omry merged commit 833e2d5 into main Oct 31, 2026
9 checks passed
@omry
omry deleted the pr317 branch October 31, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant