Repository navigation
soc_vweuda: fix login problem - #4078
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Critical login redirect behavior and additional authentication issues remain unresolved.
1 open finding
What changed in this PR
Updates VWEUDA authentication for portal changes and adds support for an additional vehicle range field.
Changes:
- Uses the portal-specific user agent.
- Adds manual login redirect and callback handling.
- Adds transient login error handling and a range-field fallback.
| File | Review summary |
|---|---|
packages/modules/vehicles/vweuda/libeuda.py |
Unresolved redirect-limit, portal-cookie priming, and ApiError.status issues; missing coverage for login flows and the new range identifier. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…in redirect to be inspected' tested, works Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
benderl
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems VW changed on VWEUDA Portal.
This PR fixes the HTTP 406 error thrown in the previous version.