Skip to content

Verbraucher: nicht erfasste Verbräuche in HV - #4080

Open
LKuemmel wants to merge 3 commits into
openWB:masterfrom
LKuemmel:consumer_dev
Open

LKuemmel wants to merge 3 commits into
openWB:masterfrom
LKuemmel:consumer_dev

Conversation

@LKuemmel

@LKuemmel LKuemmel commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Negative residual values can violate topic validation and produce invalid published data.

0 open findings

What changed in this PR

Adds calculation and MQTT publication of unmeasured household consumption across counter hierarchies.

Changes:

  • Calculates residual consumption for nested counters and hybrid systems.
  • Adds data-field, validation, topic, ACL, and test coverage.
  • Requires handling negative residuals before publication.
File Summary
packages/​helpermodules/​update_config.py Registers the MQTT topic.
packages/​helpermodules/​setdata.py Validates the new value.
packages/​control/​counter_all/​counter_home_consumption_test.py Adds residual-consumption tests.
packages/​control/​counter_all/​counter_all.py Calculates and publishes unmeasured consumption.
packages/​control/​counter_all/​counter_all_data.py Adds the data field and metadata.
data/​config/​mosquitto/​public/​default-dynamic-security.json Grants read access to the topic.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Bump the ACL version so existing installations receive the new permission.

0 open findings

Previously missed (1)

In code that hasn't changed since last review

Medium severity Bump ACL version to apply new permissions to existing installations

data/​config/​mosquitto/​public/​default-dynamic-security.json:3005

This ACL will not be applied to existing installations while the template version remains openwb-version:10 (data/config/mosquitto/public/default-dynamic-security.json:84): update_acls() returns immediately when the current and template versions match, so adding this entry only affects fresh configurations. Bump the ACL version (and its upgrade expectations) so deployed roles are reconciled.

🧠 Review effort: Lite

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All reviewed changes are covered and no unresolved blocking issues were identified.

0 open findings

🧠 Review effort: Lite

@LKuemmel
LKuemmel requested a review from AlexanderHa98 October 9, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants