[steipete]

What Problem This Solves

The development lockfile pins fast-uri 4.1.5, which is affected by four URI-handling advisories, and compatible runtime/tooling updates have accumulated.

User Impact

Installs use patched URI normalization and current compatible filesystem/runtime tooling. The acpx version remains 0.21.0 and its Node runtime floor is unchanged. The prompting guide also states precisely that bare-command help requires terminal stdin.

Why This Change Was Made

Raise the existing fast-uri override to 4.2.3 and build on the landed #903, consolidate #904, and include the other eligible in-range updates. This includes fs-safe 0.26.13, Vite 8.3.5, markdownlint-cli2 0.24.0, Stryker 10.1.1, oxlint-tsgolint 7.0.2005, and tsdown 0.23.2. Manifest ranges match the tested dependency versions. The existing 48-hour cooldown remains enabled, and SDK 1.x is retained.

Evidence

• Frozen install and pnpm supply-chain policy validation pass; pnpm audit reports zero vulnerabilities.
• The complete check command sequence passes on Node 24.22.1, run locally at low priority with formatter/linter threads and Node test concurrency limited to two: 3,076 tests pass, 19 skip, zero fail.
• The separate coverage pass has 220 passing tests; the declared flows/runtime target reaches 93.55% lines/statements, 89% branches, and 97.2% functions, above all 85% gates.
• check:docs passes. Built-CLI synthetic smoke confirms terminal help, exit 2 for each missing-prompt command, and exit 2 for bare and named commands with empty piped stdin.
• Independent isolated review of the complete final diff found no actionable P0–P2 defects.

Crabbox could not dispatch the gate because its coordinator lease lookup timed out. Validation used the permitted local fallback; the allocated lease was released.

The rebase onto the separately landed fs-safe update preserves the exact tested Git tree (16c8cbda908847fc67eb7bad4d4e144e828ae9a7) and passed another independent review against the new base.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T10:32:46.044324Z	42f4090	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[clawsweeper]

Codex review: needs maintainer review before merge.

What this changes

This PR refreshes runtime and development dependencies, patches four fast-uri advisories, and clarifies when bare acpx prints help.

Example: A contributor installs the committed dependency lockfile.

• Before: The installation selects fast-uri 4.1.5 and fs-safe 0.26.10.
• After: The installation selects patched fast-uri 4.2.3 and fs-safe 0.26.13.

Review scores

Measure	Result	What it means
Overall readiness	🦐 gold shrimp (3/6)	Useful, focused maintenance with successful reviewed-head checks and no identified defects; runtime evidence is limited to reported smoke results and automated validation.
Proof confidence	🦐 gold shrimp (3/6)	This maintainer-authored PR is outside the ordinary contributor proof gate; its body reports CLI input smoke and full local validation, while inspected CI supports compatibility without supplying a separate filesystem runtime demonstration.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Source installations retain vulnerable URI tooling and older filesystem and development dependencies.
Reason: The maintainer-authored update addresses verified advisories through existing dependency controls without adding product conventions.

Merge readiness

✅ Ready for maintainer review

Keep this PR open: it is maintainer-authored, delivers dependency fixes absent from main, and has no actionable review findings.

Priority: P2
Reviewed head: b73a118af5a750d2ade7130124ff3602f926b37d

Before merge

None.

Findings

None.

Tests

• Missing end-to-end proof: The reported built-CLI smoke has no captured output demonstrating a filesystem roundtrip with fs-safe 0.26.13.

Agent review details

How this fits together

pnpm resolves the package manifest and workspace overrides into dependencies used by the CLI filesystem runtime, documentation checks, mutation tests, and replay-viewer build.

flowchart LR
  A[Package manifest] --> B[pnpm lockfile]
  C[Workspace overrides] --> B
  B --> D[CLI filesystem runtime]
  B --> E[Development tools]
  D --> F[Workspace and session files]
  E --> G[Diagnostics and browser assets]

Loading

Technical review

Best possible solution:

Land the focused dependency refresh with the existing installation safeguards and verified checks.

Do we have a high-confidence way to reproduce the issue?

Dependency exposure is established by the main lockfile and advisory ranges; no acpx exploit or runtime failure was reproduced during this read-only review.

Is this the best way to solve the issue?

Updating the existing overrides, manifest, and generated lockfile is the smallest complete maintenance path and preserves the established dependency policy.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against fae85c3f49cd.

Provenance checked

• Dependency refresh and compatibility policy keeps the original intent (9d87e7c: Refresh mature compatible dependencies while retaining the runtime floor and release cooldown.)
• fast-uri override keeps the original intent (deb993a: Pin a patched URI implementation to remediate development dependency advisories.)
• Prompting guide keeps the original intent (924b5b6: Document missing-prompt errors accurately without changing CLI behavior.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

• Pinned changes remain necessary: The introduced diff updates fast-uri from 4.1.5 to 4.2.3 and locked fs-safe from 0.26.10 to 0.26.13; these updates are absent from the pinned main revision. (pnpm-lock.yaml:9, b73a118af5a7)
• Install safeguards preserved: The workspace retains its 2,880-minute release cooldown and disabled esbuild build script; the package retains its Node runtime floor, package-manager pin, scripts, and publishing metadata. (pnpm-workspace.yaml:1, b73a118af5a7)
• Documentation matches implementation: The bare-command handler prints help only when prompt text is absent and stdin is a terminal; readPromptInput rejects empty piped stdin. (src/cli-public.ts:48, b73a118af5a7)
• Dependency-policy applicability: The production filesystem handler imports and executes fs-safe root operations, establishing an affirmative reason to inspect that dependency's filesystem security contract. (src/filesystem.ts:9, b73a118af5a7)
• Filesystem contract reviewed: The dependency policy requires confinement and identity checks to remain intact; inspected release changes retain exact root identity and validate publication descriptors, destination identity, and link counts. (src/publication-handle.ts:9, 6c8627eb55a0)
• URI advisories verified: GitHub advisories GHSA-w74x-v6f9-j3xg, GHSA-xhq7-xmqj-769h, GHSA-wjr9-j795-jxcr, and GHSA-333x-w4r6-6crp identify affected fast-uri 4.x ranges containing 4.1.5 and first patched version 4.2.3.

Likely related people:

• Vincent Koc: Raw commit 9459d6b adds pnpm-workspace.yaml:1 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 9459d6b49c7a; files: pnpm-workspace.yaml)

Root-cause cluster

Relationship: canonical
Canonical: #910
Summary: This PR owns the consolidated development updates and extends the landed filesystem dependency refresh.

Members:

• superseded: build(deps-dev): bump the development group with 2 updates #904 - Its Markdown lint and Vite updates are included here, and the maintainer explicitly closed it in favor of this PR.
• partial_overlap: build(deps): bump @openclaw/fs-safe from 0.26.8 to 0.26.10 in the production group #903 - It landed fs-safe 0.26.10; this PR advances that dependency to 0.26.13.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Labels

Label changes:

• add P2: Patches verified development-dependency advisories and refreshes runtime tooling without evidence of an urgent exploitable acpx failure.
• add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

• P2: Patches verified development-dependency advisories and refreshes runtime tooling without evidence of an urgent exploitable acpx failure.
• rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 26, 2026, 6:14 AM ET / 10:14 UTC.

[steipete]

Additional filesystem proof on the reviewed and CI-green head: ran node dist/cli.js through the existing mock ACP adapter with an isolated HOME and synthetic workspace. This exercises the actual CLI filesystem handlers with installed fs-safe 0.26.13.

fs-safe 0.26.13: built CLI ACP write persisted 22 verified bytes
built CLI ACP read returned the exact synthetic content
built CLI ACP outside-cwd read denied; outside file unchanged and content not exposed

The write result was checked against the file bytes, the read result against the same content, and the rejected outside read against the structured ACP error. No provider credentials or real workspace data were used.

All required checks passed in CI run 40304087798.

[steipete]

Landed in 26849fd.

• Exact-head PR CI and post-merge main CI are green, including Node 22/24/26, mutation, conformance, and policy checks.
• Release workflow dry run passed on the merge commit with version 0.21.0; publishing and release creation were skipped.
• Open Dependabot alerts dropped from four to zero through the patched fast-uri override, without dismissals.
• Full local validation, independent review, CLI input smoke, and the captured filesystem write/read/confinement proof also passed.

No package version bump, tag, or release was performed. Dependabot credit is retained in the squash commit.