Repository navigation
fix: preserve CSV field marker ownership in scanner runtime - #115
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A valid CSV field's closing quote can be mistaken for the start of a removal marker and leave ordinary data incompletely inspected. Prove exact closing offsets against Python's CSV parser before refining the existing loose fallback; every field body and explicit removal instruction remains available.
Evidence
scan <original-file> --no-llm --format jsonreports partial inspection, 0/1 file andobfuscated_instruction_textfor unchanged Solarisproducts.csvandstacks/threejs.csv.After: both report complete inspection, 1/1 file, no exceptions. Each retains its same finding; every issue field except the per-run random finding ID is equal.
95a52d8; all 119 source/dependency files match reviewed producer4b0272f. Independent producer and consumer P0–P3 reviews are complete and scoped-clean.Merge Danger
Door: two-way
Blast Radius: scanner
Ownership requires complete
.csvsource, at most 1 MiB and 8,192 fields before canonical parsing, exact field/source agreement, and the existing caller deadline. Malformed, unsupported and over-budget inputs retain the conservative fallback. This is static component proof; full Solaris semantic/prod recovery remains separate.