Skip to content

test: wait for Bash timeout helper readiness - #120

Merged
Patrick-Erichsen merged 1 commit into
mainfrom
test-bash-helper-readiness
Oct 28, 2026
Merged

Patrick-Erichsen merged 1 commit into
mainfrom
test-bash-helper-readiness

Conversation

@Patrick-Erichsen

Copy link
Copy Markdown
Collaborator

Summary

The Bash helper timeout test could kill a freshly created macOS executable before it wrote its PID, so it failed without exercising the intended cleanup assertion. Wait for the actual helper to identify itself before starting the test's short timeout.

 launch real helper
+wait for matching helper PID (bounded setup)
 exercise 0.1s timeout
 assert helper is reaped

Evidence

  • Before: the unchanged test fails 5/5 in a fresh real host scanner install with FileNotFoundError: helper.pid.
  • After: the same installed scanner passes 5/5 repeated timeout runs and all 34 Bash adapter controls. The real subprocess, process-group cleanup and elapsed-time assertion remain exercised.
  • Production parser code and its 0.5s limit are unchanged. Independent P0–P3 review is clean.

Merge Danger

Door: two-way

Blast Radius: tests

@clawsweeper

clawsweeper Bot commented Oct 28, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@Patrick-Erichsen
Patrick-Erichsen merged commit ba09e85 into main Oct 28, 2026
12 checks passed
@Patrick-Erichsen
Patrick-Erichsen deleted the test-bash-helper-readiness branch October 28, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant