Repository navigation
fix: bound JavaScript native data syntax ownership - #122
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PDFGate 1.0.0 fails static inspection because a shell-parser candidate opens inside a JavaScript
Errortemplate and consumes later host code. Use bounded JavaScript parsing and individual data-use proofs to delimit owned syntax, while raw findings continue to inspect original bytes.Pin
tree-sitter==0.25.2andtree-sitter-javascript==0.25.0for.js,.mjsand.cjs. Mutable/shadowed capabilities, escaping callbacks and Error messages, classes and captured catch bindings, unknown executable uses and exhausted analysis bounds retain conservative coverage.Evidence
After: installed Linux runtime completes 5/5, with zero static limitations and identical two raw LP3/E1 MEDIUM finding payloads except generated IDs. Original helper: 12,801 bytes, SHA256
7cccd56d3e8e8c1e55430af2f9002c6dc0490b363c2c40c4205ab7025be9b7fd. Existing missing-reference caveats remain.go vetand Ruff pass. All 300 short counterexample variants across five import forms attribute opacity to the actual construction. Review regressions were reproduced against actual main before repair; short baseline completions are distinguished from newly introduced long-case regressions.Refs ClawHub #4087. Production adoption, normal original-version retry and public-byte verification follow before issue closure. Other retained parser groups remain incomplete.
Merge Danger
Door: two-way; revert the source/runtime pin.
Blast Radius: scanner. New bounded syntax ownership applies only after the individual JavaScript value/use proof; unsupported constructions retain incomplete analysis. No original artifacts or security findings are rewritten.