Repository navigation
fix: prove closed native JavaScript validator values - #123
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The unchanged
gtrk-ai-drama@1.3.9validator is left partially inspected because bounded native arrays, record values, function results and template joins lack a closed ownership proof. Add an optional JavaScript value/effect proof, leaving unknown calls, grammar and effects unsupported.The embedded patch and mirrored Docker adapter suites preserve legacy inspection, findings, parser/type budgets and dependency pins. Native
argv.slicerequires scalar start/end operands, preventing implicit coercion hooks from invalidating later identities.Evidence
**After (installed Linux package):**3/3 fully inspected, those three generated rows disappear; all six missing-reference caveats remain. Validator SHA-256
f099cc9b6613a7d61758b86e9d571e2934ae602e38243117fa235e4389e921e1is unchanged. No original code was executed.After: all five remain partial; four scalar-bound controls remain complete. All three exact independently reported examples reproduce before and stay partial after the repair.
uv.lockis unchanged. Full Go tests,go vet ./...and CLI help pass.static_parse_limittoopaque_contentwhile staying partial: lexical lookup memoization preserves22 unsupported constructions under the same100,000-step per-proof budget. The strict comparator failure is retained; a narrow verifier accepts only that traced diagnostic refinement.These are local/static proofs. Production adoption, ordinary original recovery and public/install verification follow separately. This PR does not resolve every case in openclaw/clawhub#4058.
Merge Danger
Door: two-way
The source pin can be rolled back. This does not repack original uploads or alter publication/moderation state.
Blast Radius: scanner
Incorrect ownership could hide an inspection gap; affirmative effect/native-input checks, adversarial controls and independent semantic review protect that boundary.