Repository navigation
fix: validate native PCM binary exclusion evidence - #125
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A retained upload containing ordinary PCM audio can finish text inspection but remain blocked because the adapter rejects its WAV binary exclusion. Add original-byte structural evidence and independently validate it before admitting the existing exclusion.
Only visible, non-executable
.wavassets with exact headers, sizes, frame arithmetic and padding qualify. Extra chunks/trailers, unknown codecs, truncated bytes, hidden/nested artifacts and malformed evidence fail closed. Raw findings, decoded line counts and semantic completeness remain unchanged.Related: openclaw/clawhub#4046. Production activation and original publication recovery follow separately.
Evidence
After: The installed candidate and actual Go adapter accept inventory127 / text126 and reconcile all147 references. All127 original files /1,101,503bytes and all58 findings remain unchanged; the WAV keeps its explicit binary exclusion and informational686-line count. Static-only reports still fail final LLM completion.
Merge Danger
Door: two-way
Revert the source/runtime change before adoption if needed. No data migration or publication retry is included.
Blast Radius: scanner
Extends only the pinned producer's explicit PCM binary-exclusion contract; operational completion remains separate from a security verdict or publication approval.