Skip to content

SedModel: wrong handling of models of unknown type - #630

Merged
agarny merged 2 commits into
opencor:mainfrom
agarny:issue629
Oct 18, 2026
Merged

agarny merged 2 commits into
opencor:mainfrom
agarny:issue629

Conversation

@agarny

@agarny agarny commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Fixes #629.

Such a model can be either empty or have issues with imports. As a result of fixing this, we also indirectly fixed an issue with instantiating a SED-ML document (with an empty model) from JavaScript.
Copilot AI balanced review requested due to automatic review settings October 18, 2026 22:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@agarny
agarny merged commit 30e2289 into opencor:main Oct 18, 2026
26 checks passed
@agarny
agarny deleted the issue629 branch October 18, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SedModel: wrong handling of models of unknown type

2 participants