Repository navigation
chore(deps): the bundle format comes from ctis/transfer - #8
Merged
Merged
Conversation
github.com/openctemio/sdk-go/pkg/transfer moved unchanged to the contract module github.com/openctemio/ctis/transfer (openctemio/ctis#65); a golden test there pins the published bytes to v0.1.0, so bundles written here are byte-identical. The feed no longer depends on the sensor SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundle writer now imports
github.com/openctemio/ctis/transferinstead ofgithub.com/openctemio/sdk-go/pkg/transfer. The package moved to ctis unchanged in openctemio/ctis#65, and is pinned to ctis mainbec9272.Wire compatibility: a golden test in ctis pins every published byte (chunks, signed manifest, signed pointer) to the v0.1.0 writer. Bundles written here are byte-identical, and the platform reads them through the same module (openctemio/openctem#2169).
Why: a feed is a contract between the publisher and the platform. Neither side should depend on the sensor SDK (openctem RFC-094).
Threat model: no behaviour change. Signing (DSSE, Ed25519) and the hash pinning are unchanged.
Verified:
go vet ./...andgo test ./...pass, includinginternal/bundle.