Skip to content

test that robin_surv respects reordered treatment factor levels #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielinteractive merged 1 commit into from
Sep 22, 2026
Merged

test that robin_surv respects reordered treatment factor levels #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions tests/testthat/test-survival.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,38 @@ test_that("robin_surv works as expected without strata or covariates", {
expect_snapshot_value(result$events_table, tolerance = 1e-4, style = "serialize")
})

test_that("robin_surv respects reordered treatment factor levels", {
original <- robin_surv(
Surv(time, status) ~ 1,
treatment = sex ~ sr(1),
data = surv_data
)

relabelled_data <- surv_data
levels(relabelled_data$sex) <- c("Male", "Female")
relabelled <- robin_surv(
Surv(time, status) ~ 1,
treatment = sex ~ sr(1),
data = relabelled_data
)

reordered_data <- surv_data
reordered_data$sex <- factor(reordered_data$sex, levels = c("Male", "Female"))
reordered <- robin_surv(
Surv(time, status) ~ 1,
treatment = sex ~ sr(1),
data = reordered_data
)

# Assigning `levels()` changes the labels attached to the existing factor
# codes; it does not reorder the factor. Reconstructing the factor with an
# explicit level order reverses the comparison and therefore the log HR.
expect_equal(relabelled$estimate, original$estimate)
expect_equal(reordered$estimate, -original$estimate)
expect_equal(reordered$se, original$se)
expect_identical(rownames(reordered$log_hr_coef_mat), "Female v.s. Male")
})

test_that("robin_surv gives the same results as RobinCar functions without strata or covariates", {
result <- robin_surv(
Surv(time, status) ~ 1,
Expand Down
Loading