Repository navigation
Replace Frappe Charts with Orchid Charts 0.0.13 - #3143
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Frappe Charts with
@orchidsoftware/charts0.0.13. Screens configure the five supported chart types directly throughLayout::chart(), using native options, shared labels and datasets.The package measures the actual CSS typography for legends, axes and annotations. Platform retains its 14px label styles and semantic colors, uses the standard package legend, and gives the canvas consistent card padding. Marker labels remain inside the plot without a default outline.
Update metric producers, generated chart layouts and chart examples to the native data shape. The controller replaces chart instances on config/canvas changes, waits for stylesheet loading, exports SVG and destroys instances on disconnect.
Compatibility
Chart data uses shared
labelsanddatasets.TimeCollection::toChart()andGroupCollection::toChart()return this shape. Native Orchid Charts options replace Frappe-specific options;TYPE_MIXEDreplacesTYPE_AXIS_MIXED. Pie and percentage charts require one dataset. Typed chart properties and the generated fluent layout replace the old subclass property configuration.Validation and scope
git diff --checkpassed.