Repository navigation
Follow Stimulus target lifecycle for charts - #3167
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a chart's canvas target left its chart instance alive. A config change then tried to access the missing target and prevented the replacement canvas from rendering.
Give the chart instance the same lifetime as its canvas target through Stimulus target callbacks. Declare window load and export prevention as actions in Blade. Keep chart creation behind stylesheet readiness and preserve native chart configuration.
Replace the empty controller test superclass with real Stimulus running in jsdom. Exercise attribute updates, target removal and replacement, reconnect, load and export through the DOM. Run the chart suite in CI. Rebuild the production JavaScript bundle.
Validation: nine Stimulus integration tests, 715 PHP tests with 2623 assertions, Pint, Prettier and Chromium with the actual charts package. The target-removal regression fails against the previous controller and passes with this change. Existing unrelated local Platform changes are excluded.
Independent final review returned PASS+NOTES for 2ef13d2. The source, test and config changes are identical to the first reviewed version after merging current master. Existing master CSS artifacts and their integrity metadata are preserved.